From dev-return-145864-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Jan 25 15:40:35 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A9799180651 for ; Thu, 25 Jan 2018 15:40:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99A70160C3D; Thu, 25 Jan 2018 14:40:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE9EB160C13 for ; Thu, 25 Jan 2018 15:40:34 +0100 (CET) Received: (qmail 96421 invoked by uid 500); 25 Jan 2018 14:40:33 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 96409 invoked by uid 99); 25 Jan 2018 14:40:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2018 14:40:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8D509180235; Thu, 25 Jan 2018 14:40:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.29 X-Spam-Level: ** X-Spam-Status: No, score=2.29 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lz9hdmncdEdB; Thu, 25 Jan 2018 14:40:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 913255FBED; Thu, 25 Jan 2018 14:40:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DCE04E0026; Thu, 25 Jan 2018 14:40:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4F3F3C4025B; Thu, 25 Jan 2018 14:40:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0105689547216099695==" MIME-Version: 1.0 Subject: Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions From: Marta Kuczora via Review Board To: Peter Vary , Adam Szita Cc: hive , Marta Kuczora Date: Thu, 25 Jan 2018 14:40:28 -0000 Message-ID: <20180125144028.814.22732@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Marta Kuczora X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65219/ X-Sender: Marta Kuczora References: <20180118165842.60650.90462@reviews-vm2.apache.org> In-Reply-To: <20180118165842.60650.90462@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Reply-To: Marta Kuczora X-ReviewRequest-Repository: hive-git --===============0105689547216099695== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/ ----------------------------------------------------------- (Updated Jan. 25, 2018, 2:40 p.m.) Review request for hive, Peter Vary and Adam Szita. Changes ------- Addressed the review findings. - Added tests for creating partitions with default attribute values. - Added tests for creating partitions without columns and with invalid or incomplete colum infos - Added tests for creating partitions without serde info - Added tests for creating partitions for external table with and without location being set - Made some helper methods static - Used the List.newArrayList method where it is needed - Changed the value of the MAX variable to -1 - Removed the creation time checks where it was not necessary - Fixed some checkstyle issues Bugs: HIVE-18486 https://issues.apache.org/jira/browse/HIVE-18486 Repository: hive-git Description ------- The following methods of IMetaStoreClient are covered by this test. - Partition add_partition(Partition) - int add_partitions(List) - List add_partitions(List, boolean, boolean) The test covers not just the happy pathes, but the edge cases as well. Diffs (updated) ----- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65219/diff/2/ Changes: https://reviews.apache.org/r/65219/diff/1-2/ Testing ------- Run the tests Thanks, Marta Kuczora --===============0105689547216099695==--