From dev-return-145750-archive-asf-public=cust-asf.ponee.io@hive.apache.org Mon Jan 22 16:21:13 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 86A6B180609 for ; Mon, 22 Jan 2018 16:21:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 744EF160C4B; Mon, 22 Jan 2018 15:21:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B9905160C3A for ; Mon, 22 Jan 2018 16:21:12 +0100 (CET) Received: (qmail 9744 invoked by uid 500); 22 Jan 2018 15:21:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 9468 invoked by uid 99); 22 Jan 2018 15:21:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jan 2018 15:21:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8FC0D1805D6; Mon, 22 Jan 2018 15:21:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.29 X-Spam-Level: ** X-Spam-Status: No, score=2.29 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dTdrdo7dZzQ6; Mon, 22 Jan 2018 15:21:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C9FB05F6D2; Mon, 22 Jan 2018 15:21:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AC1DE02D6; Mon, 22 Jan 2018 15:21:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7655BC40191; Mon, 22 Jan 2018 15:21:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0695862991290986804==" MIME-Version: 1.0 Subject: Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods From: Marta Kuczora via Review Board To: Peter Vary , Marta Kuczora Cc: hive , Adam Szita Date: Mon, 22 Jan 2018 15:21:06 -0000 Message-ID: <20180122152106.16052.95905@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Marta Kuczora X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65217/ X-Sender: Marta Kuczora References: <20180119142940.64727.84126@reviews-vm2.apache.org> In-Reply-To: <20180119142940.64727.84126@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Reply-To: Marta Kuczora X-ReviewRequest-Repository: hive-git --===============0695862991290986804== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195910 ----------------------------------------------------------- Thanks a lot Adam for the patch. It looks good to me, I just have few questions. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 223 (patched) When altering a partition, is it possible to modify its StorageDescriptor and location? If so, what happens if we try to modify the sd or location to null or empty? Is it possible to change the columns in the partition's storage descriptor? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 497 (patched) When tyring to alter two partitions, but an exception occurs during altering one of them, what happens with the other? All modification will be rolled back correctly? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 769 (patched) What happens if the newPart partition has different db/table than the ones set in the method parameter? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 770 (patched) What happens if the db/table is null in the newPart partition? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 771 (patched) Is it possible to change any other attribute of a partition besides the value with the rename method? - Marta Kuczora On Jan. 19, 2018, 2:29 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65217/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 2:29 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18468 > https://issues.apache.org/jira/browse/HIVE-18468 > > > Repository: hive-git > > > Description > ------- > > Adding IMetastoreClient API tests that cover alterPartition ande renamePartition methods > > > Diffs > ----- > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/65217/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > > --===============0695862991290986804==--