From dev-return-145522-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jan 9 20:29:37 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 71887180718 for ; Tue, 9 Jan 2018 20:29:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 64DD9160C2D; Tue, 9 Jan 2018 19:29:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA4E0160C17 for ; Tue, 9 Jan 2018 20:29:36 +0100 (CET) Received: (qmail 17862 invoked by uid 500); 9 Jan 2018 19:29:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 17851 invoked by uid 99); 9 Jan 2018 19:29:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 19:29:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C0440C0811; Tue, 9 Jan 2018 19:29:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.74 X-Spam-Level: *** X-Spam-Status: No, score=3.74 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id uQbm5GpBCGpx; Tue, 9 Jan 2018 19:29:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1305F5F24E; Tue, 9 Jan 2018 19:29:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AAF14E00A3; Tue, 9 Jan 2018 19:29:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7CAEEC4029D; Tue, 9 Jan 2018 19:29:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3802387607449070541==" MIME-Version: 1.0 Subject: Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long From: j.prasanth.j@gmail.com To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Cc: hive , j.prasanth.j@gmail.com Date: Tue, 09 Jan 2018 19:29:32 -0000 Message-ID: <20180109192932.56467.51888@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64900/ X-Sender: noreply@reviews.apache.org References: <20180105065541.59325.47158@reviews-vm2.apache.org> In-Reply-To: <20180105065541.59325.47158@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/groupingset_high_columns.q X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/groupingset_high_columns.q.out Reply-To: j.prasanth.j@gmail.com X-ReviewRequest-Repository: hive-git --===============3802387607449070541== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review195063 ----------------------------------------------------------- ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out Lines 94 (patched) Yes. This is very likely exposing some problems with empty rollup handling. As such this patch shouldn't cause any result diff (only expected explain diff). Do you want to handle this in HIVE-18413? - Prasanth_J On Jan. 5, 2018, 6:55 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64900/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 6:55 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-18359 > https://issues.apache.org/jira/browse/HIVE-18359 > > > Repository: hive-git > > > Description > ------- > > HIVE-18359: Extend grouping set limits from int to long > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 8b94d1d > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 90145e5 > ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java 0032305 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java adcda26 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java 89c5c23 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 6f4188c > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 28b4cfe > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5a88a96 > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 9d4ad22 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java cee0e14 > ql/src/test/queries/clientpositive/cte_1.q 15d3f06 > ql/src/test/queries/clientpositive/groupingset_high_columns.q PRE-CREATION > ql/src/test/results/clientpositive/annotate_stats_groupby.q.out ed3d594 > ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out ffcb20f > ql/src/test/results/clientpositive/auto_join25.q.out 063d3ca > ql/src/test/results/clientpositive/cte_1.q.out 9374a32 > ql/src/test/results/clientpositive/groupby_cube1.q.out e5ece81 > ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out 9a6457c > ql/src/test/results/clientpositive/groupby_grouping_id3.q.out f13b6e5 > ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out d70f065 > ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 453b9f7 > ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out be8d20e > ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out 0c6ead9 > ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 0bb12e1 > ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 5b990a1 > ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2f86b > ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out b25b0e5 > ql/src/test/results/clientpositive/groupby_grouping_window.q.out 32135e4 > ql/src/test/results/clientpositive/groupby_rollup1.q.out bc1d8a9 > ql/src/test/results/clientpositive/groupby_rollup_empty.q.out 5db3184 > ql/src/test/results/clientpositive/groupingset_high_columns.q.out PRE-CREATION > ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 5f1d264 > ql/src/test/results/clientpositive/limit_pushdown2.q.out cdd221b > ql/src/test/results/clientpositive/llap/cte_1.q.out ddef9db > ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 061b0d7 > ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out d135f08 > ql/src/test/results/clientpositive/llap/llap_acid.q.out 38889b9 > ql/src/test/results/clientpositive/llap/llap_acid_fast.q.out 4a7297d > ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 39feaec > ql/src/test/results/clientpositive/llap/sysdb.q.out 3bd407b > ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 39de888 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out 7224d59 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out e6075c7 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4b81f > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out d2b738b > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 1877bba > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 7c9f668 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 6a5e679 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4d8fa16 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 5e9e204 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out b81a0d3 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out e8ca06e > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 4de6ebb > ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out d1263cd > ql/src/test/results/clientpositive/perf/spark/query18.q.out 88d289c > ql/src/test/results/clientpositive/perf/spark/query22.q.out 15fe441 > ql/src/test/results/clientpositive/perf/spark/query27.q.out 627821f > ql/src/test/results/clientpositive/perf/spark/query36.q.out d313337 > ql/src/test/results/clientpositive/perf/spark/query5.q.out 14e0bdb > ql/src/test/results/clientpositive/perf/spark/query67.q.out 25d37bd > ql/src/test/results/clientpositive/perf/spark/query70.q.out 862bdb0 > ql/src/test/results/clientpositive/perf/spark/query77.q.out 6dcaf7c > ql/src/test/results/clientpositive/perf/spark/query80.q.out 606d23c > ql/src/test/results/clientpositive/perf/spark/query86.q.out 8e159fd > ql/src/test/results/clientpositive/spark/groupby_cube1.q.out fa1480e > ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out 460e7db > ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out f6f0043 > ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 7f7d354 > ql/src/test/results/clientpositive/vector_grouping_sets.q.out f08c270 > ql/src/test/results/clientpositive/view_cbo.q.out e10cb7a > > > Diff: https://reviews.apache.org/r/64900/diff/3/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > > --===============3802387607449070541==--