hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marta Kuczora via Review Board <>
Subject Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions
Date Thu, 25 Jan 2018 14:40:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 25, 2018, 2:40 p.m.)

Review request for hive, Peter Vary and Adam Szita.


Addressed the review findings.
- Added tests for creating partitions with default attribute values.
- Added tests for creating partitions without columns and with invalid or incomplete colum
- Added tests for creating partitions without serde info
- Added tests for creating partitions for external table with and without location being set
- Made some helper methods static
- Used the List.newArrayList method where it is needed
- Changed the value of the MAX variable to -1
- Removed the creation time checks where it was not necessary
- Fixed some checkstyle issues

Bugs: HIVE-18486

Repository: hive-git


The following methods of IMetaStoreClient are covered by this test.
- Partition add_partition(Partition)
- int add_partitions(List<Partition>)
- List<Partition> add_partitions(List<Partition>, boolean, boolean)

The test covers not just the happy pathes, but the edge cases as well.

Diffs (updated)





Run the tests


Marta Kuczora

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message