hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marta Kuczora via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods
Date Wed, 24 Jan 2018 15:41:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/
-----------------------------------------------------------

(Updated Jan. 24, 2018, 3:41 p.m.)


Review request for hive, Peter Vary and Adam Szita.


Changes
-------

Fixed some checkstyle issues and made the checks in the alter test simpler.


Bugs: HIVE-18496
    https://issues.apache.org/jira/browse/HIVE-18496


Repository: hive-git


Description
-------

The following methods of IMetaStoreClient are covered by this test.
- void createIndex(Index, Table)
- boolean dropIndex(String, String, String, boolean)
- void alter_index(String, String, String, Index)

The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-----

  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/65241/diff/3/

Changes: https://reviews.apache.org/r/65241/diff/2-3/


Testing
-------

Run the tests


Thanks,

Marta Kuczora


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message