hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)
Date Tue, 23 Jan 2018 11:49:03 GMT


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 323 (patched)
> > <https://reviews.apache.org/r/65265/diff/2/?file=1943732#file1943732line323>
> >
> >     Maybe this could be moved to a separate test case (like create table with null
location). It was a bit hard to notice after the asserts of the previous test case.

Done


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 505 (patched)
> > <https://reviews.apache.org/r/65265/diff/2/?file=1943732#file1943732line505>
> >
> >     It might be good to check if the table is really deleted.

Done. Thanks for pointing this out!


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 602 (patched)
> > <https://reviews.apache.org/r/65265/diff/2/?file=1943732#file1943732line602>
> >
> >     This test contains three well defined use cases so I think it would make sense
to split them into 3 tests.

Done


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 911 (patched)
> > <https://reviews.apache.org/r/65265/diff/2/?file=1943732#file1943732line911>
> >
> >     What happens if the location of the table is changed to null? Is it a valid
use case or an exception will occur?

Good idea. Done


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/#review195980
-----------------------------------------------------------


On Jan. 23, 2018, 11:48 a.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65265/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 11:48 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18509
>     https://issues.apache.org/jira/browse/HIVE-18509
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added the new tests.
> Modified AbstractMetaStoreService, so when starting mini-metastore it is possible to
provide configuration value overrides for non-metastore config values (like fs trash settings)
> 
> 
> Diffs
> -----
> 
>   standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
PRE-CREATION 
>   standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
ed071f8 
> 
> 
> Diff: https://reviews.apache.org/r/65265/diff/3/
> 
> 
> Testing
> -------
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message