hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepak Jaiswal <>
Subject Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements
Date Wed, 17 Jan 2018 02:27:31 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 17, 2018, 2:27 a.m.)

Review request for hive, Eugene Koifman and Jason Dere.


Implemented review comments.
Added a test for ACID tables.
Removed the strict ACID check which ensured that files are named in format 000000_0, 000000_0_copy_1
etc. The renaming is now done explicitely for non-bucketed tables.

Bugs: HIVE-18350

Repository: hive-git


Made changes for both bucketed and non-bucketed tables.
Added a positive test for non-bucketed table which renames the loaded file.
Added couple of negative tests for bucketed table which reject a load with inconsistent file

Diffs (updated)

  ql/src/java/org/apache/hadoop/hive/ql/exec/ d68d646eb4 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/ 1a2b3c1f6c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ 4535c3edc2 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/ cc1d8574b0 
  ql/src/test/queries/clientnegative/load_data_bucketed_1.q PRE-CREATION 
  ql/src/test/queries/clientnegative/load_data_bucketed_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/load_data_rename.q PRE-CREATION 
  ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 
  ql/src/test/results/clientnegative/load_data_bucketed_1.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/load_data_bucketed_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 
  ql/src/test/results/clientpositive/llap/load_data_rename.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 
  ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 





Deepak Jaiswal

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message