hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances
Date Thu, 11 Jan 2018 12:54:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65018/
-----------------------------------------------------------

(Updated Jan. 11, 2018, 12:54 p.m.)


Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.


Changes
-------

Updated the patch based on Vihang's comment


Bugs: HIVE-18372
    https://issues.apache.org/jira/browse/HIVE-18372


Repository: hive-git


Description
-------

Created:
- AbstractMetastore class - to privide an interface for different metastore implementation
(start/stop/warehouse path methods)
-- Implementation for Embedded/Remote/Cluster metastores
- MiniHMS with builder - to create hms instances for test
- MetaStoreFactory - to create the parameter list for parametrized test
- TestDatabases - test for database related metastore functions to showcase the infrastructure


Diffs (updated)
-----

  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/ClusterMetaStoreForTests.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/EmbeddedMetaStoreForTests.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/MiniHMS.java
PRE-CREATION 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/RemoteMetaStoreForTests.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/65018/diff/4/

Changes: https://reviews.apache.org/r/65018/diff/3-4/


Testing
-------

Run the new tests


Thanks,

Peter Vary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message