Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
From: Alan Gates <alanfgates@gmail.com>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Fri, 1 Dec 2017 08:02:14 -0800
Subject: Re: HMS dependency on fb303.FacebookService
Message-Id: <9C0BEA1A-0ED0-4EE3-A077-47C44691EDE6@gmail.com>
References: <CAGGNey2ueuSWyk18_5A-YEE8WkSxkpNe4yaHzwhq1k9_Fn5_hQ@mail.gmail.com> <CANQiJeX2KkLRVmuHexKZ8Bw7fFroQvgxOJngQYJJPYWSAxftTA@mail.gmail.com> <CAGGNey2pDkTg8eXvmdVpH1qypyNEN0aCH3NLut=iLzFddq8TVA@mail.gmail.com>
In-Reply-To: <CAGGNey2pDkTg8eXvmdVpH1qypyNEN0aCH3NLut=iLzFddq8TVA@mail.gmail.com>
To: dev@hive.apache.org
archived-at: Fri, 01 Dec 2017 16:02:28 -0000

Works for me.=20

Alan.=20

Sent from my iPhone

> On Nov 28, 2017, at 10:55, Alexander Kolbasov <akolb@cloudera.com> wrote:
>=20
> Thanks for the reply Alan!
>=20
> The major problem with fb303 is that it is always a pain to deal with it
> when you need to generate thrift code for other purposes. For backwards
> compatibility we may provide some simple implementation ourselves - does
> this sound reasonable?
>=20
> Alex
>=20
>> On Tue, Nov 28, 2017 at 9:35 AM, Alan Gates <alanfgates@gmail.com> wrote:=

>>=20
>> Removing this break our backwards compatibility.  This interface provides=

>> public methods like getName.  Hive may not be using them but we have no
>> idea if others are in the wild.  Given that including this has little or n=
o
>> cost to us AFAIK, why remove it?
>>=20
>> Alan.=E2=80=8B
>>=20
>> On Mon, Nov 27, 2017 at 5:21 PM, Alexander Kolbasov <akolb@cloudera.com>
>> wrote:
>>=20
>>> The hive_metastore.thrift has a dependency on  fb303.FacebookService -
>> the
>>> ThriftHiveMetastore extends it. It looks like the only thing that it is
>>> actually using is the shutdown() method.
>>>=20
>>> As an experiment I removed the dependency and the call to shutdown()
>> method
>>> and everything seems to compile just fine (I have not run any actual
>> tests
>>> yet).
>>>=20
>>> Does anyone think that FacebookService provides anything useful or it is=

>>> just an lod cruft that should be removed?
>>>=20
>>> - Alex
>>>=20
>>=20