Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AACD200D4C for ; Thu, 16 Nov 2017 06:22:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99631160BF6; Thu, 16 Nov 2017 05:22:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DD734160BF4 for ; Thu, 16 Nov 2017 06:21:59 +0100 (CET) Received: (qmail 57838 invoked by uid 500); 16 Nov 2017 05:21:58 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 57827 invoked by uid 99); 16 Nov 2017 05:21:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 05:21:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 395841807F8; Thu, 16 Nov 2017 05:21:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aF5cWxAQTlBO; Thu, 16 Nov 2017 05:21:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 416335FE22; Thu, 16 Nov 2017 05:21:50 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91ACEE0383; Thu, 16 Nov 2017 05:21:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8B96CC402DD; Thu, 16 Nov 2017 05:21:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2835809374840458871==" MIME-Version: 1.0 Subject: Re: Review Request 63806: HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero From: Vihang Karajgaonkar via Review Board To: Matt McCline , Aihua Xu Cc: Vihang Karajgaonkar , hive Date: Thu, 16 Nov 2017 05:21:49 -0000 Message-ID: <20171116052149.35835.64860@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vihang Karajgaonkar X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63806/ X-Sender: Vihang Karajgaonkar References: <20171115225020.35835.12905@reviews-vm2.apache.org> In-Reply-To: <20171115225020.35835.12905@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColModuloLongColumn.java Reply-To: Vihang Karajgaonkar X-ReviewRequest-Repository: hive-git archived-at: Thu, 16 Nov 2017 05:22:00 -0000 --===============2835809374840458871== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63806/ ----------------------------------------------------------- (Updated Nov. 16, 2017, 5:21 a.m.) Review request for hive, Aihua Xu and Matt McCline. Changes ------- added a test case Bugs: HIVE-16756 https://issues.apache.org/jira/browse/HIVE-16756 Repository: hive-git Description ------- HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero Diffs (updated) ----- ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 8b586b1f00ce7d6081f973a5736100d8941f79bc ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColModuloLongColumn.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 6d3e82e9b96e012d875d947fa397c6c67df6a931 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 21f6540512ec795171014d87a6fde0d0ea5f23cf ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java ea06ea0aefcf5e36f204eaad78131860b44298ae ql/src/test/queries/clientpositive/vectorization_div0.q 025d457807dd0642965a81c6b093e421c4acd0f8 ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 631b0723fb0d7ab011ad2bfd7be4b33d11d76b1c ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 6c3354cb4a8cd439d86df7e6b0cf759ea4c04cd0 ql/src/test/results/clientpositive/vectorization_div0.q.out 97f1687b85193e681f26c61107a6d9266c1d87a2 vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java e58d4e91938dc266111042fe98b05a3d9c6fc5e9 Diff: https://reviews.apache.org/r/63806/diff/3/ Changes: https://reviews.apache.org/r/63806/diff/2-3/ Testing ------- Thanks, Vihang Karajgaonkar --===============2835809374840458871==--