Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9DF55200D33 for ; Wed, 8 Nov 2017 20:17:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C79F160C01; Wed, 8 Nov 2017 19:17:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E3CFB1609E0 for ; Wed, 8 Nov 2017 20:17:04 +0100 (CET) Received: (qmail 43856 invoked by uid 500); 8 Nov 2017 19:17:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 43845 invoked by uid 99); 8 Nov 2017 19:17:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 19:17:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D0167C60F7; Wed, 8 Nov 2017 19:17:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fF81R8Peltzr; Wed, 8 Nov 2017 19:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8DCB660F61; Wed, 8 Nov 2017 19:17:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D87CFE0E16; Wed, 8 Nov 2017 19:17:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D02B7C410F7; Wed, 8 Nov 2017 19:17:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0663780498065208319==" MIME-Version: 1.0 Subject: Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler From: Janaki Lahorani via Review Board To: Vihang Karajgaonkar , Sahil Takiar , Andrew Sherman , Alexander Kolbasov Cc: Janaki Lahorani , hive Date: Wed, 08 Nov 2017 19:17:00 -0000 Message-ID: <20171108191700.35838.38159@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Janaki Lahorani X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63586/ X-Sender: Janaki Lahorani References: <20171107211952.26135.68008@reviews-vm2.apache.org> In-Reply-To: <20171107211952.26135.68008@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java Reply-To: Janaki Lahorani X-ReviewRequest-Repository: hive-git archived-at: Wed, 08 Nov 2017 19:17:05 -0000 --===============0663780498065208319== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/ ----------------------------------------------------------- (Updated Nov. 8, 2017, 7:17 p.m.) Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, and Vihang Karajgaonkar. Changes ------- Addressed comments from Andrew. Repository: hive-git Description ------- HMS handler thread local will have the configuration changes from the user local only to that connection. HiveAlterHandler should use the thread local to pick up user's configuration changes. Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java PRE-CREATION standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 921cfc00343807179340fbdf40f21e2a46d936ab Diff: https://reviews.apache.org/r/63586/diff/4/ Changes: https://reviews.apache.org/r/63586/diff/3-4/ Testing ------- Thanks, Janaki Lahorani --===============0663780498065208319==--