hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x
Date Wed, 29 Nov 2017 22:19:56 GMT


> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote:
> > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java
> > Line 47 (original), 46 (patched)
> > <https://reviews.apache.org/r/63972/diff/1/?file=1897953#file1897953line54>
> >
> >     is this still needed?
> 
> Gour Saha wrote:
>     Will be removed in the next pass once status and diagnostics are migrated. Its mentioned
in the jira as well.

Hmm.. what is the next pass. How will this work after the patch, would it require both YS
and Slider?


> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote:
> > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java
> > Lines 182 (patched)
> > <https://reviews.apache.org/r/63972/diff/1/?file=1897953#file1897953line216>
> >
> >     should this be configurable? or at least a constant
> 
> Gour Saha wrote:
>     Every app-package can choose their own location where they upload the package. It
doesn't has to be this specific path. As long as this same path is specified in Yarnfile (refer
templates.py). The reason I did not create a constant is because there is no other refernce
of this path in the Java land. The only other reference is from templates.py. Nevertheless
I can create a constant for it in the next pass.

Still good to have a constant for visibility, and if this is used elsewhere later


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63972/#review191563
-----------------------------------------------------------


On Nov. 21, 2017, 1:37 a.m., Gour Saha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63972/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 1:37 a.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-18037
>     https://issues.apache.org/jira/browse/HIVE-18037
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> First phase of migration of slider based llap app-package to YARN Services in Hadoop
3.x. There will be follow up changes to migrate status, log links, diagnostics and completely
eliminate Slider dependency.
> 
> 
> Diffs
> -----
> 
>   bin/ext/llap.sh 0462d26 
>   binary-package-licenses/README ef127e3 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bd25bc7 
>   jdbc/pom.xml 8710a8b 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstance.java
30b1810 
>   llap-server/bin/llapDaemon.sh 4945473 
>   llap-server/changes_for_non_slider_install.txt ec20fe1 
>   llap-server/pom.xml 176110d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java d01598c

>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 5090be2

>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java a0af554 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java 296a851

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java d2e9396

>   llap-server/src/main/resources/llap.py 26756ce 
>   llap-server/src/main/resources/package.py 21c34e9 
>   llap-server/src/main/resources/params.py 8972ba1 
>   llap-server/src/main/resources/templates.py 3d747a2 
>   packaging/src/main/assembly/bin.xml 84686ee 
> 
> 
> Diff: https://reviews.apache.org/r/63972/diff/1/
> 
> 
> Testing
> -------
> 
> Package created and successfully deployed in a Hadoop 3.0 cluster, using cmd line shell
script and programatically via Java APIs.
> 
> 
> File Attachments
> ----------------
> 
> HIVE-18037.001.patch
>   https://reviews.apache.org/media/uploaded/files/2017/11/21/e0844c04-be9b-4334-80b0-bae05e9ed885__HIVE-18037.001.patch
> 
> 
> Thanks,
> 
> Gour Saha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message