hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 64115: HIVE-18160: Jar localization during session initialization is slow
Date Tue, 28 Nov 2017 20:51:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/#review192063
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 129 (patched)
<https://reviews.apache.org/r/64115/#comment270067>

    nit: final?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 721 (patched)
<https://reviews.apache.org/r/64115/#comment270068>

    should it only log "computed..." and the time when actually computing it?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 773 (patched)
<https://reviews.apache.org/r/64115/#comment270069>

    hmm.. why is this necessary? it should still be possible to use the streaming version


- Sergey Shelukhin


On Nov. 28, 2017, 10:06 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64115/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 10:06 a.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-18160
>     https://issues.apache.org/jira/browse/HIVE-18160
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-18160: Jar localization during session initialization is slow
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15c4cabcdbd666af8a9cb8022b8898a8a72

> 
> 
> Diff: https://reviews.apache.org/r/64115/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message