hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 63927: HIVE-17631 upgrade orc to 1.4.0
Date Fri, 17 Nov 2017 22:56:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63927/#review191405
-----------------------------------------------------------




pom.xml
Line 185 (original), 185 (patched)
<https://reviews.apache.org/r/63927/#comment269214>

    Use 1.4.1?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
Lines 2124 (patched)
<https://reviews.apache.org/r/63927/#comment269218>

    This is handled by ORC-148 already. Any exception will not prune RG/Stripe.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java
Lines 147 (patched)
<https://reviews.apache.org/r/63927/#comment269215>

    looks like its already returned in close()? plz remove the TODO if so


- Prasanth_J


On Nov. 17, 2017, 10:42 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63927/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 10:42 p.m.)
> 
> 
> Review request for hive, Jason Dere and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
c32f79fe95 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
599b5191c6 
>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestIncrementalObjectSizeEstimator.java
1ec702011a 
>   pom.xml 04fb7c3c55 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 1e5b841f4b 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java cbbbb150b6 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 80b7be8e5a

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java d2bb6417a2 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java a916d58f3e 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicValue.java a20328cb69 
> 
> 
> Diff: https://reviews.apache.org/r/63927/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message