hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2
Date Thu, 16 Nov 2017 20:21:57 GMT


> On Nov. 16, 2017, 7:45 p.m., Prasanth_J wrote:
> > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
> > Lines 316 (patched)
> > <https://reviews.apache.org/r/63864/diff/1/?file=1894036#file1894036line316>
> >
> >     why would it stack overflow? I don't see a loop here.

it is sometimes called from a callback from a failed call, and in turn invokes a callback
again and retries, and since this is a failure on the same thread it does it infinitely and
very fast.
The root cause was that entity manager didn't know a node for an attempt even though TaskInfo
does... so I just use TaskInfo.
I'm not sure why there's no node in the map, the whole state management in this class seems
a bit chaotic.


> On Nov. 16, 2017, 7:45 p.m., Prasanth_J wrote:
> > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
> > Lines 414 (patched)
> > <https://reviews.apache.org/r/63864/diff/1/?file=1894037#file1894037line414>
> >
> >     or update log4j2 properties file with WARN default for WM_LOG logger.

Well, for now I want them to always be logged


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63864/#review191232
-----------------------------------------------------------


On Nov. 16, 2017, 3:36 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63864/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 3:36 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
a02a414a76 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
9dc521e39e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java a1775cd6bb

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 851245c154 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 1fe5859490 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 5ba6639e0c

> 
> 
> Diff: https://reviews.apache.org/r/63864/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message