hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM
Date Thu, 09 Nov 2017 02:05:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190530
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java
Lines 194 (patched)
<https://reviews.apache.org/r/63533/#comment267982>

    throw in that case? asserts are disabled by default



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 117 (patched)
<https://reviews.apache.org/r/63533/#comment267983>

    the are not init'ed in c'tor. so can't be made final.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 123 (patched)
<https://reviews.apache.org/r/63533/#comment267984>

    nit: Map



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 310 (patched)
<https://reviews.apache.org/r/63533/#comment267985>

    nit: Map, List



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 494 (patched)
<https://reviews.apache.org/r/63533/#comment267988>

    why are we putting back if NOT_FOUND? should this be destroyed instead? this session will
still be NOT_FOUND in next iteration of event processing right?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 1703 (patched)
<https://reviews.apache.org/r/63533/#comment267989>

    nit: print queryId as well. or add queryId to WmTezSession toString()


- Prasanth_J


On Nov. 8, 2017, 9:12 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 9:12 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc

> 
> 
> Diff: https://reviews.apache.org/r/63533/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message