hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vihang Karajgaonkar via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table
Date Mon, 06 Nov 2017 18:51:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63528/#review190193
-----------------------------------------------------------




standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
Lines 263-264 (original), 275-278 (patched)
<https://reviews.apache.org/r/63528/#comment267477>

    Shouldn't the partValues contain only the values from partBatch here?


- Vihang Karajgaonkar


On Nov. 2, 2017, 10:02 p.m., Adam Szita wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63528/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 10:02 p.m.)
> 
> 
> Review request for hive, Peter Vary and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-17969
>     https://issues.apache.org/jira/browse/HIVE-17969
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Refactoring alter table code to use batching of partitions when calling the heavy removeUnusedColumnDescriptor
method
> 
> 
> Diffs
> -----
> 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
ccadac1ada6aaae884ab39f5d99e91b8c542404e 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
62801c53853dbafb7c425cff943ec819dcee4800 
> 
> 
> Diff: https://reviews.apache.org/r/63528/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam Szita
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message