hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dere <jd...@hortonworks.com>
Subject Re: Review Request 63319: HIVE-17908: LLAP External client not correctly handling killTask for pending requests
Date Fri, 03 Nov 2017 20:39:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63319/#review190057
-----------------------------------------------------------




llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java
Lines 82 (patched)
<https://reviews.apache.org/r/63319/#comment267311>

    Whoops, will change it to non-static.



llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java
Lines 550 (patched)
<https://reviews.apache.org/r/63319/#comment267315>

    The retry could be initiated from 2 different places:
    1) From receiving a REJECTED response during the fragment submission
    2) From receiving a taskKilled notification, prior to the first task heartbeat.
    
    So both events would occur in the case that the fragment submission was rejected, and
I wanted only one of the retries issue here to take effect. The semaphore was supposed to
try to enforce that by having only one sender active at any time.
    
    Thinking about this again, I think another way to avoid this conflict would be to only
call the retry for case (2), which should work as long as it is the case that a rejected fragment
always receives a taskKilled notification. This wouldn't require the semapore.


- Jason Dere


On Oct. 26, 2017, 2:42 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63319/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2017, 2:42 a.m.)
> 
> 
> Review request for hive and Siddharth Seth.
> 
> 
> Bugs: HIVE-17908
>     https://issues.apache.org/jira/browse/HIVE-17908
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> - Pending requests should retry if killTask received
> - Change retry delay to use exponential backoff
> 
> 
> Diffs
> -----
> 
>   llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java
aa94e54 
> 
> 
> Diff: https://reviews.apache.org/r/63319/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message