hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user
Date Thu, 02 Nov 2017 18:23:17 GMT


> On Nov. 2, 2017, 5:01 p.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/cli/session/SessionManager.java
> > Lines 477 (patched)
> > <https://reviews.apache.org/r/63458/diff/2/?file=1878772#file1878772line478>
> >
> >     Can you also log the key on which limit has been reached ? (username and/or
ipaddress).
> >     It would help with troubleshooting from the server logs.

Done.


> On Nov. 2, 2017, 5:01 p.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/cli/session/SessionManager.java
> > Lines 508 (patched)
> > <https://reviews.apache.org/r/63458/diff/2/?file=1878772#file1878772line509>
> >
> >     safer to check - if( connectionCount >= limit )

Done.


- Prasanth_J


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63458/#review189929
-----------------------------------------------------------


On Nov. 2, 2017, 8:08 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63458/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 8:08 a.m.)
> 
> 
> Review request for hive, Sergey Shelukhin and Thejas Nair.
> 
> 
> Bugs: HIVE-16917
>     https://issues.apache.org/jira/browse/HIVE-16917
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a3c853a 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 9b2ae57 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 6354c8c 
>   service/src/test/org/apache/hive/service/cli/TestCLIServiceConnectionLimits.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/63458/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message