hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 63381: HIVE-17926: Support triggers for non-pool sessions
Date Thu, 02 Nov 2017 01:44:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63381/#review189863
-----------------------------------------------------------




service/src/java/org/apache/hive/service/server/HiveServer2.java
Line 140 (original), 142 (patched)
<https://reviews.apache.org/r/63381/#comment267096>

    hmm.. without calling setupPool, some fields like initConf, maybe others, that are used
in various places, will not be initialized. Is it safe?


- Sergey Shelukhin


On Oct. 31, 2017, 7:27 p.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63381/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2017, 7:27 p.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-17926
>     https://issues.apache.org/jira/browse/HIVE-17926
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-17926: Support triggers for non-pool sessions
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractJdbcTriggersTest.java PRE-CREATION

>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersNoTezSessionPool.java
PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersTezSessionPoolManager.java
aeca663 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java b67c933 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9b4714f 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 2c4fe7f 
> 
> 
> Diff: https://reviews.apache.org/r/63381/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message