Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED2F4200D27 for ; Wed, 25 Oct 2017 20:03:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EB957160BDA; Wed, 25 Oct 2017 18:03:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D5DB1609CE for ; Wed, 25 Oct 2017 20:03:38 +0200 (CEST) Received: (qmail 22012 invoked by uid 500); 25 Oct 2017 18:03:37 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 22000 invoked by uid 99); 25 Oct 2017 18:03:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 18:03:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CB8D61807F8 for ; Wed, 25 Oct 2017 18:03:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id V51C0c_n8_mB for ; Wed, 25 Oct 2017 18:03:33 +0000 (UTC) Received: from mail-qt0-f170.google.com (mail-qt0-f170.google.com [209.85.216.170]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 81CD95F477 for ; Wed, 25 Oct 2017 18:03:33 +0000 (UTC) Received: by mail-qt0-f170.google.com with SMTP id z19so1118275qtg.11 for ; Wed, 25 Oct 2017 11:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=QHwyVK7ti+o3l63IRfz4W0FfoJ7acgpt9AkXwz4tqgA=; b=eUR9zisrViC4zAtHbW00MX0+kzijmW/k9xghCPiLh97XlzuMcTHepwv/IVDjLaP2EL RlrOagd6i8M2HjWgQE+8WqloE2wO7A18HPUxX1YoZuqawIqHZfUVLj2gbhRLyeW4vOGE BuL3ELWT0KCt5nVVeZju2IQPSy1NKIshb8aXBqrTNFVXlluJjZlsGerXObQyMmKPkS49 X1tYMyUFUp8LUBQRtUsKTxG6KEeyxai3knJZsYsVbEEe/YBQ9gh2q0AT2CiapC7yLVwo IcN6nOvNGVNn6fhxxHM69LGq7xSXELGE6bDMUv//2LYIqKWnjxjJRyj5stzHHEKhwY/q 4hjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QHwyVK7ti+o3l63IRfz4W0FfoJ7acgpt9AkXwz4tqgA=; b=l3Mv9NIwEkALSp/3t7t7e1eEXebxPw4y3qTwK1lgTdVbHY7JIYKfuwTuWQu0eTs3GM fMaFaVfkkiwvatFA/fKpGhcrYJQpntALKOlDExxr9Ag1NMhQ6tVolok5wNHi7k5F1upX QxwryYehPfqHMAH9CQFsrQNT71PUK5HElJwch2xmppIb8c4sHsMqb17V0wLaoh90JFax f6+6MYRIlCd7k0VpIDd6EqkxqVpfJf2SH9feOPQYnAfUsYEuCFeNMK2/AHdSSnS9jSHr nfoRFYtdyQddvWJ746krR6FAF702/cqQtVoKa0fe1dCvgKmlGWL7ZeBqT5Pq1bU5MpMX NmBw== X-Gm-Message-State: AMCzsaWuJb+u7+VVqA6r1JjKDbN51PZCOoAYZPfubtJ1QZVTu2Xm9CCo 3Yz/A73JDLjIQla4LtJRLDmX5+LD14oLxFm/UrS2ISoh X-Google-Smtp-Source: ABhQp+TJwIEJww4CwCbIwjVYrjGlc/czPfwsbhw1BRAzbNaP1V+FtEk0CFRTs92Xy9SuIYTxUGbAqeUnRmYMkNZTe08= X-Received: by 10.200.26.99 with SMTP id q32mr31750961qtk.222.1508954607011; Wed, 25 Oct 2017 11:03:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.29.10 with HTTP; Wed, 25 Oct 2017 11:03:26 -0700 (PDT) From: Alan Gates Date: Wed, 25 Oct 2017 11:03:26 -0700 Message-ID: Subject: Question on TransactionalValidationListener To: dev@hive.apache.org Content-Type: multipart/alternative; boundary="f403045d62fc555129055c62df41" archived-at: Wed, 25 Oct 2017 18:03:39 -0000 --f403045d62fc555129055c62df41 Content-Type: text/plain; charset="UTF-8" Looking at this code in the TransactionalValidationListener, around line 186: *if *(hive_metastoreConstants.*TABLE_IS_TRANSACTIONAL*.equalsIgnoreCase(key)) { transactional = parameters.get(key); parameters.remove(key); } Why does it remove the parameter after checking? In local metastore cases where the thrift object could actually be shared between client and server, I think this could lead to a problem if someone does a create table followed by an alter table using the same thrift object. Alan. --f403045d62fc555129055c62df41--