Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DCDDB200D2E for ; Tue, 31 Oct 2017 15:30:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DB4A71609EC; Tue, 31 Oct 2017 14:30:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D95E1609EB for ; Tue, 31 Oct 2017 15:30:06 +0100 (CET) Received: (qmail 82775 invoked by uid 500); 31 Oct 2017 14:30:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 82764 invoked by uid 99); 31 Oct 2017 14:30:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 14:30:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 18D65D1A2A; Tue, 31 Oct 2017 14:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2YVnpxBC90iD; Tue, 31 Oct 2017 14:30:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 410A25FD72; Tue, 31 Oct 2017 14:30:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D5BBFE0662; Tue, 31 Oct 2017 14:30:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 12F62C403C1; Tue, 31 Oct 2017 14:29:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5648145574347058860==" MIME-Version: 1.0 Subject: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time) From: Zoltan Haindrich To: Ashutosh Chauhan Cc: hive , Zoltan Haindrich Date: Tue, 31 Oct 2017 14:29:58 -0000 Message-ID: <20171031142958.27699.80168@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zoltan Haindrich X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63442/ X-Sender: Zoltan Haindrich X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/stats_empty_partition2.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/stats_empty_partition2.q Reply-To: Zoltan Haindrich X-ReviewRequest-Repository: hive-git archived-at: Tue, 31 Oct 2017 14:30:07 -0000 --===============5648145574347058860== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63442/ ----------------------------------------------------------- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-17934 https://issues.apache.org/jira/browse/HIVE-17934 Repository: hive-git Description ------- * remove the reactive stat state guessing method * make the guessing only work when a new object is created * change the way stat objects are merged this patch will most probably break almost all qtest outputs.... Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java 7a3fae65e8c1c0090b353cdd674f9b67164695e0 ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java a4f60accce852d13a08e21261ac3a8d8ad7121e2 ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 8ffb4ce44b71e949577bc0bb7d17aa3ee9bed92f ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 9ffd12ad3c248176024b573f2d3eb23cab06ee05 ql/src/test/queries/clientpositive/stats_empty_partition2.q PRE-CREATION ql/src/test/results/clientpositive/stats_empty_partition2.q.out PRE-CREATION Diff: https://reviews.apache.org/r/63442/diff/1/ Testing ------- Thanks, Zoltan Haindrich --===============5648145574347058860==--