Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============4530475763438382459=="
MIME-Version: 1.0
Subject: Re: Review Request 63346: HIVE-17902 add a notions of default pool and
 unmanaged mapping
From: Sergey Shelukhin <sergey@hortonworks.com>
To: Harish Jaiprakash <hjp@hortonworks.com>, j.prasanth.j@gmail.com
Cc: Sergey Shelukhin <sergey@hortonworks.com>, hive <dev@hive.apache.org>
Date: Fri, 27 Oct 2017 21:22:06 -0000
Message-ID: <20171027212206.63764.5830@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Sergey Shelukhin <noreply@reviews.apache.org>
References: <20171027011008.51091.94503@reviews-vm2.apache.org>
In-Reply-To: <20171027011008.51091.94503@reviews-vm2.apache.org>
Reply-To: Sergey Shelukhin <sergey@hortonworks.com>
archived-at: Fri, 27 Oct 2017 21:22:12 -0000

--===============4530475763438382459==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 27, 2017, 1:10 a.m., Prasanth_J wrote:
> > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/63346/diff/1/?file=1869918#file1869918line7>
> >
> >     is this NON NULL by default?

I think it's null by default, based on other tables/cols in mssql schema


> On Oct. 27, 2017, 1:10 a.m., Prasanth_J wrote:
> > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
> > Line 66 (original), 67 (patched)
> > <https://reviews.apache.org/r/63346/diff/1/?file=1869918#file1869918line68>
> >
> >     if this is NULL, will it use DEFAULT_POOL_ID?

No, it means unmanaged pool. Default pool is if the mapping doesn't exist; we want the default if nothing is set up to be WM/LLAP


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189384
-----------------------------------------------------------


On Oct. 27, 2017, 12:48 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 12:48 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java f1258bab17 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 3deef0ee96 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java 3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


--===============4530475763438382459==--