Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 49514200D1E for ; Wed, 18 Oct 2017 21:12:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 47D6F160BEA; Wed, 18 Oct 2017 19:12:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D96B1609DE for ; Wed, 18 Oct 2017 21:11:59 +0200 (CEST) Received: (qmail 61618 invoked by uid 500); 18 Oct 2017 19:11:58 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 61594 invoked by uid 99); 18 Oct 2017 19:11:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 19:11:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3A6B51A217D; Wed, 18 Oct 2017 19:11:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.449 X-Spam-Level: *** X-Spam-Status: No, score=3.449 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KPh15K_Dlguc; Wed, 18 Oct 2017 19:11:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C08E15F5F7; Wed, 18 Oct 2017 19:11:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A087E0D63; Wed, 18 Oct 2017 19:11:55 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3EABBC415D2; Wed, 18 Oct 2017 19:11:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5925213896757790816==" MIME-Version: 1.0 Subject: Re: Review Request 62995: HIVE-17806: Create directory for metrics file if it doesn't exist From: Vihang Karajgaonkar via Review Board To: Sahil Takiar , Andrew Sherman , Janaki Lahorani , Aihua Xu , Vihang Karajgaonkar , Sergio Pena Cc: hive , Alexander Kolbasov Date: Wed, 18 Oct 2017 19:11:55 -0000 Message-ID: <20171018191155.63764.72801@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vihang Karajgaonkar X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62995/ X-Sender: Vihang Karajgaonkar X-ReviewBoard-ShipIt: 1 References: <20171018190720.63763.55723@reviews-vm2.apache.org> In-Reply-To: <20171018190720.63763.55723@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Vihang Karajgaonkar X-ReviewRequest-Repository: hive-git archived-at: Wed, 18 Oct 2017 19:12:00 -0000 --===============5925213896757790816== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62995/#review188551 ----------------------------------------------------------- Ship it! Ship It! - Vihang Karajgaonkar On Oct. 18, 2017, 7:07 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62995/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 7:07 p.m.) > > > Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar. > > > Bugs: HIVE-17806 > https://issues.apache.org/jira/browse/HIVE-17806 > > > Repository: hive-git > > > Description > ------- > > HIVE-17806: Create directory for metrics file if it doesn't exist > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java 96243cb74a154b9a639ffb080256c4b43bd35a4b > common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java 254af7d4310578e3883c0dffa64bed0f823696ea > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java f71bb25463b56bc741f989454664397996b6a5cf > > > Diff: https://reviews.apache.org/r/62995/diff/3/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > > --===============5925213896757790816==--