Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 98EC6200D0A for ; Wed, 4 Oct 2017 20:04:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 973A01609DD; Wed, 4 Oct 2017 18:04:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DDC5E1609D6 for ; Wed, 4 Oct 2017 20:04:21 +0200 (CEST) Received: (qmail 67850 invoked by uid 500); 4 Oct 2017 18:04:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 67839 invoked by uid 99); 4 Oct 2017 18:04:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Oct 2017 18:04:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BD22FC7700; Wed, 4 Oct 2017 18:04:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XFHp6gNz_XuK; Wed, 4 Oct 2017 18:04:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 466685FE43; Wed, 4 Oct 2017 18:04:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 993BCE03EE; Wed, 4 Oct 2017 18:04:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7CD3AC40845; Wed, 4 Oct 2017 18:04:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3212257598527481542==" MIME-Version: 1.0 Subject: Review Request 62776: HIVE-16511 CBO looses inner casts on constants of complex type From: Vineet Garg To: Ashutosh Chauhan , Teddy Choi Cc: hive , Vineet Garg Date: Wed, 04 Oct 2017 18:04:17 -0000 Message-ID: <20171004180417.34866.47117@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vineet Garg X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62776/ X-Sender: Vineet Garg X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/min_structvalue.q.out Reply-To: Vineet Garg X-ReviewRequest-Repository: hive-git archived-at: Wed, 04 Oct 2017 18:04:22 -0000 --===============3212257598527481542== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62776/ ----------------------------------------------------------- Review request for hive, Ashutosh Chauhan and Teddy Choi. Bugs: HIVE-16511 https://issues.apache.org/jira/browse/HIVE-16511 Repository: hive-git Description ------- This patch fixes an issue with CBO where after generating logical plan null constants will lose it's cast operator. Diffs ----- itests/src/test/resources/testconfiguration.properties 038487f134 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java fcebb6fbce ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 165f8c4317 ql/src/test/results/clientpositive/llap/vector_coalesce.q.out d6865dd0ad ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out ddc1d7be7b ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out b63d1e4527 ql/src/test/results/clientpositive/min_structvalue.q.out PRE-CREATION ql/src/test/results/clientpositive/perf/spark/query36.q.out c072728803 ql/src/test/results/clientpositive/perf/spark/query70.q.out 716665bd4f ql/src/test/results/clientpositive/perf/spark/query86.q.out c5b25e8467 ql/src/test/results/clientpositive/perf/tez/query36.q.out dee62b58f1 ql/src/test/results/clientpositive/perf/tez/query70.q.out d700d60345 ql/src/test/results/clientpositive/perf/tez/query86.q.out 6b59dd254f ql/src/test/results/clientpositive/vector_coalesce.q.out 445a246cb6 Diff: https://reviews.apache.org/r/62776/diff/1/ Testing ------- Thanks, Vineet Garg --===============3212257598527481542==--