hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 63230: HIVE-17841 implement applying the resource plan
Date Fri, 27 Oct 2017 18:39:12 GMT


> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/63230/diff/2/?file=1867959#file1867959line146>
> >
> >     use notEmpty.awaitUninterruptibly() ? won't wake up for spurious interrupts.
no need to loop with that.
> 
> Sergey Shelukhin wrote:
>     Hmm... I don't like setting things to wait forever as I've seen it cause bugs many
times in the past. With the loop, it rechecks the pool so it's harder to introduce bugs, although
now it's strictly speaking unnecessary to recheck

Makes sense. Will drop it. There is also a potential for lost notification which will cause
infinite wait.


- Prasanth_J


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63230/#review189249
-----------------------------------------------------------


On Oct. 27, 2017, 2:43 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63230/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 2:43 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 892ebfa166 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java 35d380c92b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java d978a25b14

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java 45c3e38dcc

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java a326db3ab0

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SessionExpirationTracker.java da93a3a791

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java b67c933b19 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9b4714f1d7

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 613522357e

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 144816862d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 81d6b859a6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 00501eef93 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java d725e90475 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
209cf57a6a 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 59efd43be6

>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 258a865fef

> 
> 
> Diff: https://reviews.apache.org/r/63230/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message