hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 63230: HIVE-17841 implement applying the resource plan
Date Fri, 27 Oct 2017 18:37:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63230/#review189456
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java
Lines 83 (patched)
<https://reviews.apache.org/r/63230/#comment266556>

    Agreed. But you can schedule a new instance of CompletableFuture that completeExceptionally
after timeout. 
    You can compose this instance of timeout CompletableFuture with other SettableFutures
to single CompletableFuture with acceptEither.
    
    So you either get timeout or some completed future.


- Prasanth_J


On Oct. 27, 2017, 2:43 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63230/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 2:43 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 892ebfa166 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java 35d380c92b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java d978a25b14

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java 45c3e38dcc

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java a326db3ab0

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SessionExpirationTracker.java da93a3a791

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java b67c933b19 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9b4714f1d7

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 613522357e

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 144816862d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 81d6b859a6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 00501eef93 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java d725e90475 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
209cf57a6a 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 59efd43be6

>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 258a865fef

> 
> 
> Diff: https://reviews.apache.org/r/63230/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message