hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harish Jaiprakash <...@hortonworks.com>
Subject Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping
Date Fri, 27 Oct 2017 05:57:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189399
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Lines 878 (patched)
<https://reviews.apache.org/r/63346/#comment266496>

    Desc is overwritten in the loop, so only the last alter statement will take into effect.



ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java
Lines 63 (patched)
<https://reviews.apache.org/r/63346/#comment266498>

    Should this be called defaultPoolPath, we should only use pool path everywhere right?



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 9608 (patched)
<https://reviews.apache.org/r/63346/#comment266497>

    We should filter this by rp_id too.



standalone-metastore/src/main/thrift/hive_metastore.thrift
Line 1050 (original), 1051 (patched)
<https://reviews.apache.org/r/63346/#comment266499>

    I made a mistake here, it should be called poolPath, not pool name. We do not need parentPoolName
and poolName when we have poolPath.


- Harish Jaiprakash


On Oct. 27, 2017, 6:18 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 6:18 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
f1258bab17 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
3deef0ee96 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message