hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 63124: HIVE-16603
Date Thu, 19 Oct 2017 17:17:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63124/#review188700
-----------------------------------------------------------




standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 3955-3956 (original), 4003-4004 (patched)
<https://reviews.apache.org/r/63124/#comment265712>

    These calls should be done outside of for() loop, else its called multiple times for each
FK.


- Ashutosh Chauhan


On Oct. 18, 2017, 8:59 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63124/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 8:59 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-16603
>     https://issues.apache.org/jira/browse/HIVE-16603
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16603
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientnegative/alter_table_constraint_invalid_ref.q PRE-CREATION

>   ql/src/test/queries/clientnegative/create_with_fk_pk_same_tab.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_with_fk_uk_same_tab.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_with_fk_wrong_ref.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_with_fk_wrong_ref2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/create_with_constraints.q 9700b5cd09e6578bbfedadbb0fc58c19a320c616

>   ql/src/test/results/clientnegative/alter_table_constraint_invalid_ref.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/create_with_fk_pk_same_tab.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/create_with_fk_uk_same_tab.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/create_with_fk_wrong_ref.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/create_with_fk_wrong_ref2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/create_with_constraints.q.out a675a0e6d51741505fe58680cd4a3675669b9c53

>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
ffb2abdf6294dbd470525ad888bd95feac7e7f06 
> 
> 
> Diff: https://reviews.apache.org/r/63124/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message