hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Kolbasov <ako...@gmail.com>
Subject Re: Review Request 62995: HIVE-17806 Create directory for metrics file if it doesn't exist
Date Tue, 17 Oct 2017 00:35:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62995/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 12:35 a.m.)


Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil Takiar,
and Vihang Karajgaonkar.


Changes
-------

Addressed code review comments from Andrew


Bugs: HIVE-17806
    https://issues.apache.org/jira/browse/HIVE-17806


Repository: hive-git


Description
-------

HIVE-17806 Create directory for metrics file if it doesn't exist


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
96243cb74a154b9a639ffb080256c4b43bd35a4b 
  common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
254af7d4310578e3883c0dffa64bed0f823696ea 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
f71bb25463b56bc741f989454664397996b6a5cf 


Diff: https://reviews.apache.org/r/62995/diff/2/

Changes: https://reviews.apache.org/r/62995/diff/1-2/


Testing
-------


Thanks,

Alexander Kolbasov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message