hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Sherman via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 62995: HIVE-17806 Create directory for metrics file if it doesn't exist
Date Mon, 16 Oct 2017 22:16:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62995/#review188223
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Line 89 (original), 92 (patched)
<https://reviews.apache.org/r/62995/#comment265238>

    comment refers to old name



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Line 102 (original), 105 (patched)
<https://reviews.apache.org/r/62995/#comment265240>

    should this say "in" the same directory ?



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Line 173 (original), 188 (patched)
<https://reviews.apache.org/r/62995/#comment265241>

    should be "temporary" not yemporary



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
Line 164 (original), 179 (patched)
<https://reviews.apache.org/r/62995/#comment265243>

    should be"temporary"


- Andrew Sherman


On Oct. 13, 2017, 11:18 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62995/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 11:18 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil
Takiar, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-17806
>     https://issues.apache.org/jira/browse/HIVE-17806
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-17806 Create directory for metrics file if it doesn't exist
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
96243cb74a154b9a639ffb080256c4b43bd35a4b 
>   common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
254af7d4310578e3883c0dffa64bed0f823696ea 
>   standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
f71bb25463b56bc741f989454664397996b6a5cf 
> 
> 
> Diff: https://reviews.apache.org/r/62995/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message