hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sahil Takiar <takiar.sa...@gmail.com>
Subject Re: Review Request 62693: HIVE-17635: Add unit tests to CompactionTxnHandler and use PreparedStatements for queries
Date Thu, 12 Oct 2017 17:34:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62693/#review187818
-----------------------------------------------------------




metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Line 387 (original), 411 (patched)
<https://reviews.apache.org/r/62693/#comment264865>

    What is this for?



metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Line 413 (original), 444 (patched)
<https://reviews.apache.org/r/62693/#comment264861>

    Is this necessary?



metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Line 432 (original), 475 (patched)
<https://reviews.apache.org/r/62693/#comment264864>

    If we are changing this, should we just use try-with-resources.



metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java
Lines 158 (patched)
<https://reviews.apache.org/r/62693/#comment264869>

    why is a new return value necessary?



metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java
Lines 170 (patched)
<https://reviews.apache.org/r/62693/#comment264868>

    nit: extra newline



metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java
Lines 192 (patched)
<https://reviews.apache.org/r/62693/#comment264867>

    nit: delete newline


- Sahil Takiar


On Sept. 29, 2017, 4:51 p.m., Andrew Sherman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62693/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 4:51 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Add a unit test which exercises CompactionTxnHandler.markFailed() and change it to use
PreparedStament.
> Add test for checkFailedCompactions() and change it to use PreparedStatement
> Add a unit test which exercises purgeCompactionHistory().
> Add buildQueryWithINClauseStrings() which is suitable for building in clauses for PreparedStatement
> Add test code to TestTxnUtils to tickle code in TxnUtils.buildQueryWithINClauseStrings()
so that it produces multiple queries.
> Change markCleaned() to use PreparedStatement
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java 84963af10ec13979a7b3976be434efbc21cf2382

>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java 60839faa352cbf959041a455e9e780dfca0afdc3

>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java 30b155f3b3311fed6cd79e46a5b2abcee9927d91

>   metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnUtils.java 1497c00e5dc77c02e53767b014a23e5fd8cb5b29

>   ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java f8ae86bea3fe78374c0e0487d66c661f4f0d78ff

> 
> 
> Diff: https://reviews.apache.org/r/62693/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Sherman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message