Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 900E7200D0C for ; Wed, 6 Sep 2017 01:24:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8E6CD160DDD; Tue, 5 Sep 2017 23:24:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D5D5F1609EF for ; Wed, 6 Sep 2017 01:24:48 +0200 (CEST) Received: (qmail 32211 invoked by uid 500); 5 Sep 2017 23:24:46 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 32200 invoked by uid 99); 5 Sep 2017 23:24:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2017 23:24:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D29F2CAF7B; Tue, 5 Sep 2017 23:24:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9SxG1jkRZ-jq; Tue, 5 Sep 2017 23:24:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D562D5FB98; Tue, 5 Sep 2017 23:24:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A6D9E00C9; Tue, 5 Sep 2017 23:24:40 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 624D4C41694; Tue, 5 Sep 2017 23:24:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4716152907607899528==" MIME-Version: 1.0 Subject: Re: Review Request 62092: HIVE-17368 : DBTokenStore fails to connect in Kerberos enabled remote HMS environment From: Vihang Karajgaonkar To: Sergio Pena , Janaki Lahorani , Aihua Xu , Sahil Takiar Cc: Vihang Karajgaonkar , hive Date: Tue, 05 Sep 2017 23:24:40 -0000 Message-ID: <20170905232440.63456.75055@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vihang Karajgaonkar X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62092/ X-Sender: Vihang Karajgaonkar References: <20170905185310.63444.49321@reviews-vm2.apache.org> In-Reply-To: <20170905185310.63444.49321@reviews-vm2.apache.org> Reply-To: Vihang Karajgaonkar X-ReviewRequest-Repository: hive-git archived-at: Tue, 05 Sep 2017 23:24:49 -0000 --===============4716152907607899528== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62092/ ----------------------------------------------------------- (Updated Sept. 5, 2017, 11:24 p.m.) Review request for hive, Aihua Xu, Janaki Lahorani, Sergio Pena, and Sahil Takiar. Changes ------- addressed review comments. Bugs: HIVE-17368 https://issues.apache.org/jira/browse/HIVE-17368 Repository: hive-git Description ------- HIVE-17368 : DBTokenStore fails to connect in Kerberos enabled remote HMS environment Diffs (updated) ----- itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java bbec37eea76517e9d42e60b26d85cd0b22965cc9 itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java d690aaa673a50785561750f4f461ec867b6f0abc itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoopAuthBridge23.java 36a9ea830a62496351103bde143bc9dd22c9ba23 itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 71f9640ad217ad60377720489e1ccc71506e51d7 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ffce1d1aec8728840bb8ef726db1b600a9aeef38 service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 00a7e742cabd2fc36faa464b29250b5a6a9b1159 shims/common/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java d6dc0796e77591d3afca8dbd29c3aa0eff255dd0 shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 5299e18743aa45c539287b335f95e8ce8df0fc35 shims/common/src/main/java/org/apache/hadoop/hive/thrift/HiveDelegationTokenManager.java b3e4a7608282be603e79d1d101679e239a5219b0 Diff: https://reviews.apache.org/r/62092/diff/2/ Changes: https://reviews.apache.org/r/62092/diff/1-2/ Testing ------- Thanks, Vihang Karajgaonkar --===============4716152907607899528==--