hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <the...@hortonworks.com>
Subject Re: Review Request 62695: HIVE-17649: Export/Import: Move export data write to a task
Date Fri, 29 Sep 2017 19:56:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62695/#review186735
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
Line 80 (original), 82 (patched)
<https://reviews.apache.org/r/62695/#comment263534>

    return void here ?
    And remove AuthEntities member variable as well ?



ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
Line 159 (original), 161 (patched)
<https://reviews.apache.org/r/62695/#comment263533>

    the authEntitites computation can be skipped with this change. right ?


- Thejas Nair


On Sept. 29, 2017, 5:31 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62695/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 5:31 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-17649
>     https://issues.apache.org/jira/browse/HIVE-17649
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-17649
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java fe9b624 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java f9991d9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java b8c6ea9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java ed43272 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62695/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message