hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 62596: HIVE-17611: Add new LazyBinary SerDe for faster writes
Date Tue, 26 Sep 2017 22:06:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62596/#review186332
-----------------------------------------------------------




serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe2.java
Lines 261 (patched)
<https://reviews.apache.org/r/62596/#comment262849>

    nit: redundant



serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe2.java
Lines 531 (patched)
<https://reviews.apache.org/r/62596/#comment262851>

    nit: white space


- Prasanth_J


On Sept. 26, 2017, 9:10 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62596/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 9:10 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Bugs: HIVE-17611
>     https://issues.apache.org/jira/browse/HIVE-17611
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Create new LazyBinarySerDe2 class which derives from LazyBinarySerDe.
> Avoid the ObjectInspector getCategory()/getPrimitiveCategory() calls for every row/column
by making those calls during initialization and creating serialization objects for each column.
Then serialization of the row is just a matter of calling serialize() on these pre-initialized
objects.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4814fcd 
>   ql/src/test/queries/clientpositive/input_lazyserde2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/input_lazyserde2.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 7ab2083

>   serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe2.java PRE-CREATION

>   serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinaryFast.java 13c73be

>   serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java 0cd5736

>   serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe2.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/62596/diff/1/
> 
> 
> Testing
> -------
> 
> Junit, qfile tests added based on existing LazyBinarySerDe tests.
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message