hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Kolbasov <ako...@gmail.com>
Subject Re: Review Request 62487: HIVE-17563: CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location
Date Fri, 22 Sep 2017 16:01:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62487/
-----------------------------------------------------------

(Updated Sept. 22, 2017, 4:01 p.m.)


Review request for hive, Aihua Xu, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

removed unused imports


Summary (updated)
-----------------

HIVE-17563: CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location


Bugs: HIVE-17563
    https://issues.apache.org/jira/browse/HIVE-17563


Repository: hive-git


Description (updated)
-------

HIVE-17563: CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
c07517a634e35c936d6ea68e9a2874ac2c59929a 
  common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
67f81d6c43a7904dc384cfcce6f948f1f802144c 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
b804cdade07079955a65cb431fab078dcecd53b1 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/metrics/TestMetrics.java
259a4db43905c47d873776df96210a4e77d07076 


Diff: https://reviews.apache.org/r/62487/diff/3/

Changes: https://reviews.apache.org/r/62487/diff/2-3/


Testing
-------

TestCodahaleMetrics tests that the json reporter functionality


Thanks,

Alexander Kolbasov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message