hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Kolbasov <ako...@gmail.com>
Subject Re: Review Request 62487: HIVE-17563 CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location
Date Thu, 21 Sep 2017 23:49:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62487/
-----------------------------------------------------------

(Updated Sept. 21, 2017, 11:49 p.m.)


Review request for hive, Aihua Xu, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.


Bugs: HIVE-17563
    https://issues.apache.org/jira/browse/HIVE-17563


Repository: hive-git


Description
-------

HIVE-17563 CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location

A few other changes included:

- Test clean up
- provide useful name for JSON reporter thread


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
c07517a634e35c936d6ea68e9a2874ac2c59929a 
  common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
67f81d6c43a7904dc384cfcce6f948f1f802144c 


Diff: https://reviews.apache.org/r/62487/diff/1/


Testing
-------

TestCodahaleMetrics tests that the json reporter functionality


Thanks,

Alexander Kolbasov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message