hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ratandeep Ratti <rdsr...@gmail.com>
Subject Re: Review Request 62321: HIVE-17530: ClassCastException when converting uniontype
Date Fri, 15 Sep 2017 13:59:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62321/#review185485
-----------------------------------------------------------


Ship it!




LGTM

- Ratandeep Ratti


On Sept. 15, 2017, 1:52 a.m., Anthony Hsu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62321/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2017, 1:52 a.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: HIVE-17530
>     https://issues.apache.org/jira/browse/HIVE-17530
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Previously, StandardUnionObjectInspector was creating an ArrayList instead of a StandardUnion,
causing the exception
> 
> ```
> java.lang.ClassCastException: java.util.ArrayList cannot be cast to org.apache.hadoop.hive.serde2.objectinspector.UnionObject
> ```
> 
> This patch fixes this.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorDeserializeRow.java 2ad06fc12869e74e14aae7b7a36685482c4a1ade

>   ql/src/test/queries/clientpositive/orc_avro_partition_uniontype.q PRE-CREATION 
>   ql/src/test/results/clientpositive/orc_avro_partition_uniontype.q.out PRE-CREATION

>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
7921de8d9c4a56af715de5498954794aaba32fff 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SettableUnionObjectInspector.java
564d8d60451d9756eca1f1edcc84248e4f559828 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java
7b2868233f127899c7dca07d4f899b24ae2cbc1b 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java
2e1bb22cea715501749ee5e169ce34f7dc789e64 
> 
> 
> Diff: https://reviews.apache.org/r/62321/diff/2/
> 
> 
> Testing
> -------
> 
> Added qtest.
> 
> 
> Thanks,
> 
> Anthony Hsu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message