hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml
Date Thu, 17 Aug 2017 16:16:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/#review183137
-----------------------------------------------------------



It is a bigger patch, you might want to run yetus to see if it has any comments :)

Otherwise I like your approach.
One question below.

Thanks,
Peter


metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 550 (patched)
<https://reviews.apache.org/r/61712/#comment259148>

    Why not use the HashMap(Map<? extends K,? extends V> m) constructor to use the defaults?


- Peter Vary


On Aug. 17, 2017, 2:27 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61712/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2017, 2:27 p.m.)
> 
> 
> Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.
> 
> 
> Bugs: HIVE-17319
>     https://issues.apache.org/jira/browse/HIVE-17319
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 897fc4efd4c541ee2da30516c933647f5d4a0af4

>   metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java b722af6ceb8375c76c3a393cee79ed2387555b69

>   metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61712/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message