hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 61656: HIVE-17316: Use regular expressions for the hidden configuration variables
Date Tue, 15 Aug 2017 15:03:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61656/#review182946
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
Lines 21 (patched)
<https://reviews.apache.org/r/61656/#comment258907>

    nit: Is this needed?



common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
Lines 42 (patched)
<https://reviews.apache.org/r/61656/#comment258908>

    nit: Is this needed?



common/src/test/org/apache/hadoop/hive/conf/TestHiveConfRestrictList.java
Line 44 (original), 44 (patched)
<https://reviews.apache.org/r/61656/#comment258909>

    Why does this needed?



common/src/test/org/apache/hadoop/hive/conf/TestHiveConfUntil.java
Lines 29 (patched)
<https://reviews.apache.org/r/61656/#comment258906>

    nit: Until -> Util? :)



common/src/test/org/apache/hadoop/hive/conf/TestHiveConfUntil.java
Lines 44 (patched)
<https://reviews.apache.org/r/61656/#comment258910>

    What happens if the user uses conf.get("dummyBoolean")


- Peter Vary


On Aug. 15, 2017, 1:33 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61656/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 1:33 p.m.)
> 
> 
> Review request for hive and Peter Vary.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-17316: Use regular expressions for the hidden configuration variables
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 056f2d78346b6b306d34dfb610e3a7fed4ca68aa

>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 9084fed9fa5121285709874923b3e03e887cb20d

>   common/src/test/org/apache/hadoop/hive/conf/TestHiveConfRestrictList.java 980fa761541d72a0b37bc5d687e1fbc4551b5282

>   common/src/test/org/apache/hadoop/hive/conf/TestHiveConfUntil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61656/diff/1/
> 
> 
> Testing
> -------
> 
> Added unit tests and checked that the current set of restricted variables will not restrict
any new ones due to the change in the check from equals to contains.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message