hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 61586: HIVE-17286
Date Fri, 11 Aug 2017 00:50:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61586/#review182654
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimatorFactory.java
Lines 39-41 (original), 38-40 (patched)
<https://reviews.apache.org/r/61586/#comment258630>

    This logic can now be modified to say magic[0] = buf[0]. No need to create stream.



common/src/java/org/apache/hadoop/hive/common/ndv/hll/HyperLogLog.java
Line 587 (original), 588 (patched)
<https://reviews.apache.org/r/61586/#comment258632>

    Need to close stream.



ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java
Lines 184 (patched)
<https://reviews.apache.org/r/61586/#comment258634>

    Printing whole string is not useful. Lets print only first 2 bytes in buffer. That will
be header : FM or HL. No need of encoding.



ql/src/test/results/clientpositive/char_udf1.q.out
Line 409 (original), 409 (patched)
<https://reviews.apache.org/r/61586/#comment258638>

    surprised to see this change. Since this patch should not have changed this.



ql/src/test/results/clientpositive/compute_stats_date.q.out
Line 46 (original), 46 (patched)
<https://reviews.apache.org/r/61586/#comment258639>

    doesnt look like base64encoded.


- Ashutosh Chauhan


On Aug. 10, 2017, 11:17 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61586/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 11:17 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17286
>     https://issues.apache.org/jira/browse/HIVE-17286
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-17286
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/ndv/FMSketch.java 160ce663ba5068ad029d51f431b87a40f97341a5

>   common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimator.java 4517b694ee38fd02ff32430ef24720d91c092f3a

>   common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimatorFactory.java
6a29859df56f7d41b87d95242367f6ef401b4060 
>   common/src/java/org/apache/hadoop/hive/common/ndv/fm/FMSketchUtils.java b6f7fdda0c9363516f610d5280c3c4e0821cba09

>   common/src/java/org/apache/hadoop/hive/common/ndv/hll/HyperLogLog.java 182560afbe6a8b9e2ac10591a520603bac0eb8d5

>   common/src/test/org/apache/hadoop/hive/common/ndv/fm/TestFMSketchSerialization.java
74fdf58d2d3640a9e923e3dbd96f0704ba3b5f35 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 73754fff857367f78793cbe5d976b5386a60b0b3

>   metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java d53ea4c5b2f294bbd4d530ce06a9a3fd1e640bde

>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DateColumnStatsAggregator.java
6fae3e50673aa1d4a46b1487b62c2381effdafa7 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java
c5e72ebd43a3e036c5aa03b70afcf8531ba83d32 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DoubleColumnStatsAggregator.java
e55c41230d5302de5e820649394797048b503f1c 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/LongColumnStatsAggregator.java
2ee09f3c47da0777dcebdc34b710335b8e66e50c 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/StringColumnStatsAggregator.java
2ea2fcca05de38f630592f4d4c309c1579ca04af 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/merge/DateColumnStatsMerger.java
2542a00d361b6b2be532b9288b5958c680fa40fa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMerger.java
4e8e1297585c18edc40fa71a3e33c0310b99750a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/merge/DoubleColumnStatsMerger.java
4ef5c39d1c107a329023f38769b60045b7499fb4 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/merge/LongColumnStatsMerger.java
acf7f03c72adb64696f5d7c3e0cd1bb64e34f7fd 
>   metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/merge/StringColumnStatsMerger.java
b3cd33c671ec8b478e233124671627238288a4e3 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestOldSchema.java 54828f2289657470e1da02cdb938dd14ef6488af

>   ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java d96f432fee9f4dde4ba76a21a28005299d3f9f7a

>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java
23800734f7f7a00e363b367db2e197bd3b4f640a 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 8ee41bfab2b44e6c8b345fe5d9e3f6b30d2a328c

>   ql/src/test/results/clientpositive/autoColumnStats_4.q.out e84499995b2c5cae1d84ef4f37532423dd0eac9b

>   ql/src/test/results/clientpositive/autoColumnStats_5.q.out 29963975d38aa89a96744645a097278b7ce64f1f

>   ql/src/test/results/clientpositive/autoColumnStats_6.q.out 1b125701d7c92fea66d1e6234e9a86a7b1922b17

>   ql/src/test/results/clientpositive/autoColumnStats_7.q.out 9e2121e0deae1deb37b7f1222c22aea8c6839f48

>   ql/src/test/results/clientpositive/autoColumnStats_8.q.out cdf2082d53356d18ed445b0d04b6673133878b2d

>   ql/src/test/results/clientpositive/autoColumnStats_9.q.out e32c884c7d77b739f9ec114ae9eeb08da6aabb92

>   ql/src/test/results/clientpositive/char_udf1.q.out e701d64357aadca542d82caba9a19f0d5392c328

>   ql/src/test/results/clientpositive/column_pruner_multiple_children.q.out 00e53dc3e9a9dd375f341f0beb0a794c3f201166

>   ql/src/test/results/clientpositive/columnstats_partlvl.q.out c0f007159d3c4d67eb61077cfcde670e8abad77d

>   ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 0cb4863a17f566a3f336fcf414428817281d54a9

>   ql/src/test/results/clientpositive/columnstats_quoting.q.out 7e080fec9bb21aeede72b17141e7c4ce0c1c11cd

>   ql/src/test/results/clientpositive/columnstats_tbllvl.q.out b85c1ff721d61be540e951ff5d60c1751da17b09

>   ql/src/test/results/clientpositive/compute_stats_date.q.out 78d04f9dfcb85c59c443158de17e3773a5c92564

>   ql/src/test/results/clientpositive/compute_stats_decimal.q.out e18b9890623d8cafd89c7eea59c0ace762f8e3b2

>   ql/src/test/results/clientpositive/compute_stats_double.q.out d937c3a00292fc850c8dff54721fffec82a9bc00

>   ql/src/test/results/clientpositive/compute_stats_empty_table.q.out 05042c9e42f492b30e04adb853dc8565d80595bb

>   ql/src/test/results/clientpositive/compute_stats_long.q.out 3451072a1bb81c76f7edaf56f2da5b3aaa60a3f5

>   ql/src/test/results/clientpositive/compute_stats_string.q.out bbb236150e2de488411b1cb518239ee82892e04b

>   ql/src/test/results/clientpositive/constant_prop_2.q.out 93050417c62718093595b73282214aab835532d9

>   ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 7cb62a8a94ca3fa001bc19a77d501e5692a7b11b

>   ql/src/test/results/clientpositive/exec_parallel_column_stats.q.out f6c4237ca7d8c4dc6d01d0b2ead668b9eaf43e0d

>   ql/src/test/results/clientpositive/fm-sketch.q.out 2bd218b4c82c2964d2c3ede12942f3b774d44e4c

>   ql/src/test/results/clientpositive/hll.q.out 13da13087e00f5fbad84505f1b7a818c27de9628

>   ql/src/test/results/clientpositive/llap/column_table_stats.q.out c7726fec3017bd780977834a1c526a23912cd0f7

>   ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out 6dff50f9f19f643decfbce6a761ee0878337c65a

>   ql/src/test/results/clientpositive/llap/llap_stats.q.out fda614f7b5d8c18639ed0b418dd7b49d9ad89e90

>   ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 57498a6d8f5367bda343fa663f69e95e177928f7

>   ql/src/test/results/clientpositive/llap/varchar_udf1.q.out 023d51ccb8e66498c365cda6a06b70a9926edf8c

>   ql/src/test/results/clientpositive/llap/vector_udf1.q.out b8d19c56374ba4518517ed27417db646d7816153

>   ql/src/test/results/clientpositive/parallel_colstats.q.out d5bce1ec77ab6bd2417a6be1312d28c8a3f7282b

>   ql/src/test/results/clientpositive/partial_column_stats.q.out 452d4b688c253516e233e5364458fe202b539c5c

>   ql/src/test/results/clientpositive/reduceSinkDeDuplication_pRS_key_empty.q.out 124a4b489a1decc93c38d65ca1af8cacd2cc4f6f

>   ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out 8d94ac6b07f8cf12ae7184de899e522cdc418cfe

>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 9d47066297c9f73c7432e8bed578c397059bf43d

>   ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 1764164a918d7af79bb5056e68557419e71b601d

>   standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp d178f10a21861b776b7a1e7e904f18a51e5b8c4c

>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/BinaryColumnStatsData.java
eeb510587a93d8c48224bacba557cf7fcaa61831 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/BooleanColumnStatsData.java
de39d21abe6a0437264a6dcdc1953c6a387fa4a3 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DateColumnStatsData.java
edc87a195b8471f5434aebee6cf3c75ba67e3394 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DecimalColumnStatsData.java
ec363dcbdad5b8f31e2e69b3b09615dd941f3dd0 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DoubleColumnStatsData.java
e3340e412d3c22165e5dd199a67d07df0d12f97b 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LongColumnStatsData.java
440470654fc836b5218b995f29efeca2ef9124cd 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StringColumnStatsData.java
c9afe877d63b620291b3d5fe47c8f54465cfdd0c 
>   standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 02c5717c54f2e9bbc39767a3ea3512d9618553e4

>   standalone-metastore/src/main/thrift/hive_metastore.thrift 042a5d8d0b3e1e63ee4d7f832b4d6c0cdacb513f

> 
> 
> Diff: https://reviews.apache.org/r/61586/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message