Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 44B90200CD1 for ; Wed, 26 Jul 2017 10:11:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 43673168582; Wed, 26 Jul 2017 08:11:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 88EF7168580 for ; Wed, 26 Jul 2017 10:11:08 +0200 (CEST) Received: (qmail 33634 invoked by uid 500); 26 Jul 2017 08:11:07 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 33586 invoked by uid 99); 26 Jul 2017 08:11:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 08:11:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8F07FC02A9; Wed, 26 Jul 2017 08:11:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gEKnvIHkejIp; Wed, 26 Jul 2017 08:11:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D06155F340; Wed, 26 Jul 2017 08:11:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BDE5E00A7; Wed, 26 Jul 2017 08:11:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CCCD1C4005C; Wed, 26 Jul 2017 08:11:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5344681395993829310==" MIME-Version: 1.0 Subject: Re: Review Request 60433: HIVE-16784: Missing lineage information when hive.blobstore.optimizations.enabled is true From: Barna Zsombor Klara To: Sergio Pena , Marta Kuczora , Sahil Takiar Cc: Barna Zsombor Klara , hive Date: Wed, 26 Jul 2017 08:11:03 -0000 Message-ID: <20170726081103.51161.37649@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Barna Zsombor Klara X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60433/ X-Sender: Barna Zsombor Klara References: <20170725212912.22659.20368@reviews-vm2.apache.org> In-Reply-To: <20170725212912.22659.20368@reviews-vm2.apache.org> Reply-To: Barna Zsombor Klara X-ReviewRequest-Repository: hive-git archived-at: Wed, 26 Jul 2017 08:11:09 -0000 --===============5344681395993829310== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 25, 2017, 9:29 p.m., Sahil Takiar wrote: > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/TestGenMapRedUtilsCreateConditionalTask.java > > Lines 57 (patched) > > > > > > Whats this change for? This is needed to prevent an NPE in GenMapRedUtils#mergeMovePaths. If the Session is not initialized Session.get() will return null. - Barna Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60433/#review181386 ----------------------------------------------------------- On July 17, 2017, 2:08 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60433/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 2:08 p.m.) > > > Review request for hive, Marta Kuczora, Sergio Pena, and Sahil Takiar. > > > Repository: hive-git > > > Description > ------- > > HIVE-16784: Missing lineage information when hive.blobstore.optimizations.enabled is true > > > Diffs > ----- > > itests/hive-blobstore/src/test/results/clientpositive/insert_blobstore_to_blobstore.q.out 46518999358be9ec5191ad2c3b37f555efbec263 > itests/hive-blobstore/src/test/results/clientpositive/insert_empty_into_blobstore.q.out 8e5e09627b3a0f5c66a01fdd096b4b17b0b10689 > itests/hive-blobstore/src/test/results/clientpositive/insert_into_table.q.out 663a57274840a84a5f04777540d09d9f9bcfb5da > itests/hive-blobstore/src/test/results/clientpositive/insert_overwrite_table.q.out 8052fd86eefaff1fe7d024d3f58f6896e7223dd9 > itests/hive-blobstore/src/test/results/clientpositive/orc_format_nonpart.q.out f4705687ff4b7b29d9bd6b81dfcb4065364c2965 > itests/hive-blobstore/src/test/results/clientpositive/orc_format_part.q.out 1ef98104c5a711ef4b6553ca06fccf9003b99361 > itests/hive-blobstore/src/test/results/clientpositive/orc_nonstd_partitions_loc.q.out 9de4190072cc779b34e556a0e774ce7403324525 > itests/hive-blobstore/src/test/results/clientpositive/rcfile_format_nonpart.q.out 44a1f11fa2c7bd32c636b9bad4e4e35d79989dcf > itests/hive-blobstore/src/test/results/clientpositive/rcfile_format_part.q.out defca3bb78d4d97a327c389650d256a2cd880899 > itests/hive-blobstore/src/test/results/clientpositive/rcfile_nonstd_partitions_loc.q.out 5db9c7ef90c81524eae3eb6ec5346321e38b2a9e > itests/hive-blobstore/src/test/results/clientpositive/zero_rows_blobstore.q.out 590f947add9b34d3adb05a7e22b0eb7d011c9a0d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 88bf82999953346bc92dac17c07373e6360be232 > ql/src/java/org/apache/hadoop/hive/ql/session/LineageState.java 0f9506376c283ec6e6ab659b20a5718807268969 > ql/src/test/org/apache/hadoop/hive/ql/optimizer/TestGenMapRedUtilsCreateConditionalTask.java 68ccda9ef61744e369638ceec5c083c77524c2db > > > Diff: https://reviews.apache.org/r/60433/diff/2/ > > > Testing > ------- > > > Thanks, > > Barna Zsombor Klara > > --===============5344681395993829310==--