Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17715200CC4 for ; Thu, 13 Jul 2017 18:27:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1685516BA5D; Thu, 13 Jul 2017 16:27:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5C45016B9E2 for ; Thu, 13 Jul 2017 18:27:06 +0200 (CEST) Received: (qmail 75739 invoked by uid 500); 13 Jul 2017 16:27:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 75728 invoked by uid 99); 13 Jul 2017 16:27:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 16:27:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 99CE11A0641; Thu, 13 Jul 2017 16:27:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lFNyALkk5AnT; Thu, 13 Jul 2017 16:27:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D75FA5FE4D; Thu, 13 Jul 2017 16:27:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 42FE3E0059; Thu, 13 Jul 2017 16:27:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 32C8CC400A0; Thu, 13 Jul 2017 16:27:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2481085002212923851==" MIME-Version: 1.0 Subject: Re: Review Request 60804: HIVE-17072: Make the parallelized timeout configurable in BeeLine tests From: Peter Vary To: Peter Vary Cc: hive , Marta Kuczora Date: Thu, 13 Jul 2017 16:27:02 -0000 Message-ID: <20170713162702.59900.29747@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Peter Vary X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60804/ X-Sender: Peter Vary References: <20170712154921.48722.31619@reviews-vm2.apache.org> In-Reply-To: <20170712154921.48722.31619@reviews-vm2.apache.org> Reply-To: Peter Vary X-ReviewRequest-Repository: hive-git archived-at: Thu, 13 Jul 2017 16:27:07 -0000 --===============2481085002212923851== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60804/#review180438 ----------------------------------------------------------- Thanks for the patch One nit only: it might be easier to read if we use the default value in getproperty. What do you think? - Peter Vary On júl. 12, 2017, 3:49 du, Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60804/ > ----------------------------------------------------------- > > (Updated júl. 12, 2017, 3:49 du) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-17072 > https://issues.apache.org/jira/browse/HIVE-17072 > > > Repository: hive-git > > > Description > ------- > > Made the timeout configurable in the Parallelized.java. > > > Diffs > ----- > > itests/util/src/main/java/org/apache/hive/beeline/Parallelized.java a819e26 > > > Diff: https://reviews.apache.org/r/60804/diff/1/ > > > Testing > ------- > > Ran the BeeLine tests with different timeout parameters and also without providing the parameter. > > > Thanks, > > Marta Kuczora > > --===============2481085002212923851==--