Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AFA29200CC5 for ; Tue, 11 Jul 2017 21:29:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ACD9E167095; Tue, 11 Jul 2017 19:29:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A41F5167091 for ; Tue, 11 Jul 2017 21:29:09 +0200 (CEST) Received: (qmail 4886 invoked by uid 500); 11 Jul 2017 19:29:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 4862 invoked by uid 99); 11 Jul 2017 19:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2017 19:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E4697195E54; Tue, 11 Jul 2017 19:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.75 X-Spam-Level: *** X-Spam-Status: No, score=3.75 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3CbsFEj6LaJK; Tue, 11 Jul 2017 19:28:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EEBEF6244B; Tue, 11 Jul 2017 19:22:13 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 535C3E0059; Tue, 11 Jul 2017 19:22:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DA9EFC400A0; Tue, 11 Jul 2017 19:22:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1597307506710109893==" MIME-Version: 1.0 Subject: Re: Review Request 60468: HIVE-16888 From: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= To: Ashutosh Chauhan Cc: Slim Bouguerra , hive , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Date: Tue, 11 Jul 2017 19:22:11 -0000 Message-ID: <20170711192211.38507.63844@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews=2E?=@reviews.apache.org, =?utf-8?q?apache=2Eorg=3E?=@reviews.apache.org X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60468/ X-Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews?= =?utf-8?b?LmFwYWNoZS5vcmc+?= References: <20170710220520.33458.81958@reviews-vm2.apache.org> In-Reply-To: <20170710220520.33458.81958@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewSubstitutionVisitor.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/SubstitutionVisitor.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewRule.java Reply-To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cjcamachorodriguez?=@reviews.apache.org, =?utf-8?q?=40hortonworks=2Ecom=3E?=@reviews.apache.org X-ReviewRequest-Repository: hive-git archived-at: Tue, 11 Jul 2017 19:29:10 -0000 --===============1597307506710109893== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/vector_date_1.q.out > > Line 594 (original), 594 (patched) > > > > > > seems like predicate: and (dt1 > 1970-01-01) and (dt1 >= 1970-01-01) and (1970-01-01 < dt1) and (1970-01-01 <= dt1)) simplifed to true, but should have been simplified to false. Original filter is: ((dt1 = 2001-01-01) and (2001-01-01 = dt1) and (dt1 <> 1970-01-01) and (1970-01-01 <> dt1) and (dt1 > 1970-01-01) and (dt1 >= 1970-01-01) and (1970-01-01 < dt1) and (1970-01-01 <= dt1)) (type: boolean) Since conjuncts 1 and 2 are the same -> ((2001-01-01 = dt1) and (dt1 <> 1970-01-01) and (1970-01-01 <> dt1) and (dt1 > 1970-01-01) and (dt1 >= 1970-01-01) and (1970-01-01 < dt1) and (1970-01-01 <= dt1)) (type: boolean) Since conjuncts 4 and 6 are the same -> ((2001-01-01 = dt1) and (1970-01-01 <> dt1) and (1970-01-01 <> dt1) and (dt1 > 1970-01-01) and (dt1 >= 1970-01-01) and (1970-01-01 <= dt1)) (type: boolean) Since conjuncts 5 and 6 are the same -> ((2001-01-01 = dt1) and (1970-01-01 <> dt1) and (1970-01-01 <> dt1) and (dt1 > 1970-01-01) and (dt1 >= 1970-01-01)) (type: boolean) Since conjunct 1 implies conjuncts 4 and 5 -> ((2001-01-01 = dt1) and (1970-01-01 <> dt1) and (1970-01-01 <> dt1)) We could simplify it even further, but currently we do not handle inequality predicates in the range simplification (I think Remus had raised this issue before, certainly worth tackling in a follow-up). - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/#review180071 ----------------------------------------------------------- On June 28, 2017, 7:56 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60468/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 7:56 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16888 > https://issues.apache.org/jira/browse/HIVE-16888 > > > Repository: hive-git > > > Description > ------- > > HIVE-16888 > > > Diffs > ----- > > accumulo-handler/src/test/results/positive/accumulo_predicate_pushdown.q.out 93b10a86ab42c01dddd3743c5eb4e3915e93827b > accumulo-handler/src/test/results/positive/accumulo_queries.q.out de82857c253a3de58be422dc8f6e67b267e9db32 > data/conf/hive-log4j2.properties 1124d57992863b8358165cbf06f972b99891c33f > hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out 0d72bdc72e3e609140bc622daf4f2b5bbce99aca > hbase-handler/src/test/results/positive/hbase_queries.q.out 276b6b8328d3352a58ed57060b727624afeb32bb > hbase-handler/src/test/results/positive/ppd_key_ranges.q.out 189777759f34e2ed60687ef28ef7e5d7726129fb > pom.xml 85f1222e65e03f17eb67826d2188735f7de123a4 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java e339d0a7dd4d102ff6cbac436a937b63675f068c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java 279d1015c2a5b75c6543b87654dc1d893acdfde1 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java 81de33fa2acf8b680034dabb9aea00bda424b69a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewSubstitutionVisitor.java e32f1a63d28d3af187701b532c879b3995c529c5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/SubstitutionVisitor.java 93dcc0e0a116d9c808587d350df0e6eaece0e12f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java a43d2be230a570b59845cf7ef5bce53455eb0269 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java b1efbbdaa61e1603f44fe5e402b8885864ba97ac > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java 52ca3b00cd0fefdc63f92ed4c6297b9e01c8792a > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 88054e7379663b1bb2ab0c7b07e14c61f9f4b7bf > ql/src/test/queries/clientpositive/materialized_view_create.q 57f8bb79e69714a4b419bafab73aba55e3d6bc40 > ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q e95a868fd3d499647f3fc017cae77a65bbdad5b8 > ql/src/test/results/clientpositive/auto_join12.q.out 2fdd39f39fe1fb5a0b1266bf947e849c3c10b032 > ql/src/test/results/clientpositive/auto_join16.q.out c4d654a6e22b57960394c38b1bec71cd8c8d0e02 > ql/src/test/results/clientpositive/auto_join4.q.out d4fb977d7c5e98fbec231d73bd9abb979c27a2c0 > ql/src/test/results/clientpositive/auto_join5.q.out c3b562de990e291e8d1f8bf5ed086b87f28aeb9b > ql/src/test/results/clientpositive/auto_join8.q.out 5ca6798f29d9aa62d9feb0aedaaae11615f50930 > ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out 041621fe0c4c870366ac6278e589e83a911fb995 > ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out a2f5dbf37b2da6ae84e49ff8e46f1c957aff3fdb > ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out 6d6a38a84382997317871cda94f8a69503fba6fa > ql/src/test/results/clientpositive/druid_basic2.q.out 38b07be967dd8a0bcb00afa43c1cc59742372802 > ql/src/test/results/clientpositive/druid_intervals.q.out 90013c6b6b20ad09a399decf691b074b2f09568e > ql/src/test/results/clientpositive/druid_timeseries.q.out bd4d6deebf4e1124c0656ea5ecbcdc5f28266dc6 > ql/src/test/results/clientpositive/druid_topn.q.out 5fa644614c249c3f5a17bab593646ec94e6b459d > ql/src/test/results/clientpositive/filter_union.q.out e0f7ac3c80d4c910bab5e18a83e686f674f10382 > ql/src/test/results/clientpositive/fouter_join_ppr.q.out 2dfcc180c1e55830c135deac01c4ea61228aac5b > ql/src/test/results/clientpositive/groupby_position.q.out 0a6c4a4014f732e774859c40753e3426f9bc7164 > ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 3444efc76fe2c55290fc957b676a9b5eb805a551 > ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 86cf47a62e4df4e4bd7886050352f47553e7b375 > ql/src/test/results/clientpositive/join12.q.out b3d399719466945baac88476916706d5ba8a3140 > ql/src/test/results/clientpositive/join16.q.out 61d072acd6fc524279a82f172f13143cd0199ac9 > ql/src/test/results/clientpositive/join4.q.out 0bd1edd6afa275cd7d7afe5860864c12952da39f > ql/src/test/results/clientpositive/join5.q.out d981c742ac9651d621a0164eecc414ebd81a87f4 > ql/src/test/results/clientpositive/join8.q.out 124b47ec95c24d3a3ac7ff96610b296f03d34fed > ql/src/test/results/clientpositive/join_filters_overlap.q.out 8ef37a440913a86f8af0ca98d125e31c2e86cf2b > ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out 841ef1456d57e90a6e0d3e7073fd894abf5ae99a > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out b53b2ed69b465399eae39ec4e9ae50f640eb90d1 > ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 123276795a4b33ee083e3a0c9bbad7e046e1ddaf > ql/src/test/results/clientpositive/llap/filter_union.q.out 17f10dff478f180408be5a1680b2573cda9a23c7 > ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out df32ad4ae3bb1c4ad5613bc58ac5f21d404e168e > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ceccc88b2e0cd435c37560c9e2d07e9c1f8a5310 > ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out def04a88479fd495c5e110a09e1a5a1afee57320 > ql/src/test/results/clientpositive/llap/vector_date_1.q.out e8f32afdeca97e515dbbd56950e33f89e95156d9 > ql/src/test/results/clientpositive/louter_join_ppr.q.out a4de6671fcc0dd4b15cb2cce591a4051fe2aaee6 > ql/src/test/results/clientpositive/masking_4.q.out 36889e6750d06b6b3adcccad12a5a11a243a1c96 > ql/src/test/results/clientpositive/materialized_view_create.q.out fc88dbcd3619880a2a675c8a7a9d2e3ec9799d3f > ql/src/test/results/clientpositive/materialized_view_create_rewrite.q.out 041621fe0c4c870366ac6278e589e83a911fb995 > ql/src/test/results/clientpositive/outer_join_ppr.q.out 09f30b8be156915f1a67398c0e4ca9f035be2ab0 > ql/src/test/results/clientpositive/perf/query1.q.out 9c5d440e3a39a73dbb2cde9d0a105a9edadae6f3 > ql/src/test/results/clientpositive/perf/query14.q.out 42bad8da148c2b8352cc6843ff892b20720d22e0 > ql/src/test/results/clientpositive/perf/query30.q.out 29f2061e75cd03471ab695cc6264d7eb21671b10 > ql/src/test/results/clientpositive/perf/query6.q.out 03fff799516a3ae87840512ebc706a3c75568f31 > ql/src/test/results/clientpositive/perf/query81.q.out c7571fe1d80f8224d61d5d4f378b6d78fcd128c1 > ql/src/test/results/clientpositive/ppd_gby.q.out a36bb60af3b326cba1ce1bd228a448e820144dd4 > ql/src/test/results/clientpositive/ppd_gby2.q.out d434905679bb69209ffc00a9ac79b27e0898f496 > ql/src/test/results/clientpositive/ppd_gby_join.q.out ed91def43f799055477afbef3e1f8d88405d6618 > ql/src/test/results/clientpositive/ppd_join.q.out e48c5e2bd3b665166e8c737ebc0fd8d79be4c3d1 > ql/src/test/results/clientpositive/ppd_outer_join1.q.out f4d8089ed9eb93dbf9c03304151190115f674dd8 > ql/src/test/results/clientpositive/ppd_outer_join2.q.out 8ce86d1f7bd22a0ce34efe7146f5fae82c043780 > ql/src/test/results/clientpositive/ppd_outer_join3.q.out b8b61686802fd8d3c65af2cf39d71d75e75709b0 > ql/src/test/results/clientpositive/ppd_outer_join4.q.out e8e9b556cd220f525a154b800e8db88a50f092db > ql/src/test/results/clientpositive/ppd_union.q.out 6f231b86e5cbb4c557f6b13525316964d22e79f0 > ql/src/test/results/clientpositive/ppd_vc.q.out 86ab427107091a41a6ca9db629ec498f926bda69 > ql/src/test/results/clientpositive/rcfile_null_value.q.out f3ab47cfe9706793a8c9ea979a32ed179abd8d8f > ql/src/test/results/clientpositive/router_join_ppr.q.out f17959b91b53d7254a8271b9741f5a76a21c4562 > ql/src/test/results/clientpositive/spark/auto_join12.q.out 15a94b186d8636616c748a140cdba44a70e67a4f > ql/src/test/results/clientpositive/spark/auto_join16.q.out 4217eebd849d93059c5696d36b86bc6b4f78a1ab > ql/src/test/results/clientpositive/spark/auto_join4.q.out b212b54bf176402886f2415e25f9a9d2482aec61 > ql/src/test/results/clientpositive/spark/auto_join5.q.out 422623891a478be69fe0ac1a6b048544ba0d6ca7 > ql/src/test/results/clientpositive/spark/auto_join8.q.out 5fdc5dfd05cf2f34e71b06dd75a42499e34933ff > ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 602ccb21da063e5a2926354e419a1fe5b44442ae > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out cdb69db27022c531688f01d563e19c3c5fa8908c > ql/src/test/results/clientpositive/spark/bucket_map_join_tez2.q.out 729da5e0f1e5b4501bd4e87e7716cafecd375e95 > ql/src/test/results/clientpositive/spark/groupby_position.q.out 163c5abcf81e859adc2d49cb6f47b6ae180750dc > ql/src/test/results/clientpositive/spark/join12.q.out 88bacf587de71bbb81b573f2740548d31f5ecb6b > ql/src/test/results/clientpositive/spark/join16.q.out 15adae3392f1da81620aec22afbd7b38df4925fa > ql/src/test/results/clientpositive/spark/join4.q.out 8ccc907b6c66550202b698398d18d66d428645c9 > ql/src/test/results/clientpositive/spark/join5.q.out 2ab020ed1899da085e94fc228fef106f747feb29 > ql/src/test/results/clientpositive/spark/join8.q.out f8faaa7de7a62a6a8bfc2f27f6de8c3afdf185ea > ql/src/test/results/clientpositive/spark/join_filters_overlap.q.out ac056b7dc0b7ebbf8edce9588c429a50dafdfb6b > ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 5de7733c51717ee94e41f2b840bf3b7ea2c87da7 > ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out b2ab7d714c309d9fc1771fe6bee1b898bd3fbd35 > ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out d01674e79bacfdb3381999db95dd09afebe17339 > ql/src/test/results/clientpositive/spark/ppd_join.q.out 85cd8c00cd4689ff74d18afb90074391d088ae9d > ql/src/test/results/clientpositive/spark/ppd_outer_join1.q.out 7f60d981c97c36d82d24e408de58fc742dcf4e12 > ql/src/test/results/clientpositive/spark/ppd_outer_join2.q.out 61dc19c2f780e9373642b511eb4a8be3b033005e > ql/src/test/results/clientpositive/spark/ppd_outer_join3.q.out c47a42412e82b80c0fb221aa546810960fbc530a > ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 711c4c484cdf01c9e340ad40a0274c4f4c8c66cc > ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 907977b47d02adb627ee06c8e17e317c5716aec1 > ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out 56d6bb9ce8386d3385c88ee4240be496207097a5 > ql/src/test/results/clientpositive/vector_date_1.q.out 6762374cde1d885150bac1dc41300c77b0bb022c > > > Diff: https://reviews.apache.org/r/60468/diff/2/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============1597307506710109893==--