hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PRASHANT GOLASH via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.
Date Thu, 20 Jul 2017 00:39:24 GMT


> On July 19, 2017, 10:12 p.m., Chao Sun wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 283 (patched)
> > <https://reviews.apache.org/r/60950/diff/4/?file=1780072#file1780072line283>
> >
> >     These do not seem unnecessary. Maybe replace with:
> >     ```
> >     private static final ThreadLocal<HMSHandler> threadLocalHMSHandler = new
ThreadLocal<>();
> >     ```
> >     ?

Done.


> On July 19, 2017, 10:12 p.m., Chao Sun wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 382 (patched)
> > <https://reviews.apache.org/r/60950/diff/4/?file=1780072#file1780072line382>
> >
> >     Maybe we can move this line before 375?

Though the comment mentioned that all fields are final, yet i see that base class ListenerEvent
has some set methods for e.g setEnvironmentContext. Though same object has been passed to
transactionalListeners, I am not 100% sure of the behavior with respect to normal listeners.
Would prefer to keep this same.


- PRASHANT


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180981
-----------------------------------------------------------


On July 19, 2017, 8:49 p.m., PRASHANT GOLASH wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 8:49 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call
cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so
called the notification code in that function.
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
fd4527e653 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930 
> 
> 
> Diff: https://reviews.apache.org/r/60950/diff/4/
> 
> 
> Testing
> -------
> 
> Added unit test cases for the affected codepath.
> 
> 
> Thanks,
> 
> PRASHANT GOLASH
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message