hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PRASHANT GOLASH via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.
Date Wed, 19 Jul 2017 20:49:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------

(Updated July 19, 2017, 8:49 p.m.)


Review request for hive.


Changes
-------

Addressed code review comments.


Repository: hive-git


Description
-------

Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore
(In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification
code in that function.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
fd4527e653 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930 


Diff: https://reviews.apache.org/r/60950/diff/4/

Changes: https://reviews.apache.org/r/60950/diff/3-4/


Testing
-------

Added unit test cases for the affected codepath.


Thanks,

PRASHANT GOLASH


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message