hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 60804: HIVE-17072: Make the parallelized timeout configurable in BeeLine tests
Date Thu, 13 Jul 2017 16:27:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60804/#review180438
-----------------------------------------------------------



Thanks for the patch
One nit only: it might be easier to read if we use the default value in getproperty. What
do you think?

- Peter Vary


On júl. 12, 2017, 3:49 du, Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60804/
> -----------------------------------------------------------
> 
> (Updated júl. 12, 2017, 3:49 du)
> 
> 
> Review request for hive and Peter Vary.
> 
> 
> Bugs: HIVE-17072
>     https://issues.apache.org/jira/browse/HIVE-17072
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Made the timeout configurable in the Parallelized.java.
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hive/beeline/Parallelized.java a819e26 
> 
> 
> Diff: https://reviews.apache.org/r/60804/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the BeeLine tests with different timeout parameters and also without providing the
parameter.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message