hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join
Date Tue, 11 Jul 2017 22:16:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60757/#review180251
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
Line 1965 (original)
<https://reviews.apache.org/r/60757/#comment255329>

    Did you intend to remove break; from here?


- Ashutosh Chauhan


On July 11, 2017, 10:07 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60757/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 10:07 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17066
>     https://issues.apache.org/jira/browse/HIVE-17066
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch improves estimation of number of nulls for columns coming out of outer join.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
ae32a28c66 
>   ql/src/test/results/clientpositive/annotate_stats_join.q.out 48ba40ef41 
>   ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out b4d46d28e9 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out ba96de2fe1 
>   ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out b970dd6716 
>   ql/src/test/results/clientpositive/llap/correlationoptimizer2.q.out 6067c77f85 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 88c4a17bad

>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out bb42e45c2d 
>   ql/src/test/results/clientpositive/llap/explainuser_4.q.out 99db828d6a 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out e401f31e52 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out a876c620e3 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 018ef1db54 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 3a0d1464c5 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 703d19de05 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_1.q.out 6dd3fbf6ca 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out f434a1e00b 
>   ql/src/test/results/clientpositive/llap/tez_join_tests.q.out b0eff1e1f4 
>   ql/src/test/results/clientpositive/llap/tez_joins_explain.q.out 418c23c16d 
>   ql/src/test/results/clientpositive/llap/tez_smb_empty.q.out cd392a7b2b 
>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_1.q.out 3b47383803

>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 6eba119ca0

>   ql/src/test/results/clientpositive/llap/vector_left_outer_join.q.out 82111bb27f 
>   ql/src/test/results/clientpositive/llap/vector_outer_join1.q.out f64e7393d9 
>   ql/src/test/results/clientpositive/llap/vector_outer_join2.q.out c24a2d0e6e 
>   ql/src/test/results/clientpositive/llap/vectorized_mapjoin.q.out e56800ad40 
>   ql/src/test/results/clientpositive/llap/vectorized_nested_mapjoin.q.out ed28530eec

>   ql/src/test/results/clientpositive/llap/vectorized_shufflejoin.q.out a750d9fd01 
>   ql/src/test/results/clientpositive/llap/windowing_gby.q.out 945f8e0caf 
>   ql/src/test/results/clientpositive/perf/query14.q.out 42bad8da14 
>   ql/src/test/results/clientpositive/perf/query23.q.out ebd2271108 
>   ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out d09bc52155 
>   ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out 14535f63da 
> 
> 
> Diff: https://reviews.apache.org/r/60757/diff/2/
> 
> 
> Testing
> -------
> 
> Updated existing tests
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message