hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengcheng xiong <pxi...@hortonworks.com>
Subject Re: Review Request 60776: HIVE-16907: "INSERT INTO" overwrite old data when destination table encapsulated by backquote
Date Tue, 11 Jul 2017 17:54:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60776/#review180224
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
Lines 346 (patched)
<https://reviews.apache.org/r/60776/#comment255291>

    thanks Nemon Lou for discovering this and thanks Bing Li for the patch. However, it seems
to me that although hive parse "`tdb.t1`" as a whole table name in AST, when it really processes
it, it treats it as tdb.t1. Can u check other db's behavior, e.g., oracle and postgres, mysql
for this? I doubt that there is a bug for table name when it contains "dot" in current hive.


- pengcheng xiong


On July 11, 2017, 3:51 p.m., Bing Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60776/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 3:51 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-16907
>     https://issues.apache.org/jira/browse/HIVE-16907
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Wrong behavior when the target table is written as `db.table`
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 136e951 
> 
> 
> Diff: https://reviews.apache.org/r/60776/diff/1/
> 
> 
> Testing
> -------
> 
> explain insert into default.tbl3 select * from tbl2;
> explain insert into `default.tbl3` select * from tbl2;
> 
> create table `default.xxx`(col int);
> create table default.yyy (col int);
> 
> 
> Thanks,
> 
> Bing Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message