Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============1040316689888703595=="
MIME-Version: 1.0
Subject: Re: Review Request 57009: HIVE-16029 - COLLECT_SET and COLLECT_LIST
 does not return NULL in the result
From: Eric Lin <eric.lin@cloudera.com>
To: Aihua Xu <axu@cloudera.com>
Cc: Eric Lin <eric.lin@cloudera.com>, hive <dev@hive.apache.org>
Date: Sun, 11 Jun 2017 04:40:16 -0000
Message-ID: <20170611044016.52917.83424@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Eric Lin <noreply@reviews.apache.org>
References: <20170224160854.1739.38012@reviews.apache.org>
In-Reply-To: <20170224160854.1739.38012@reviews.apache.org>
Reply-To: Eric Lin <eric.lin@cloudera.com>
archived-at: Sun, 11 Jun 2017 04:40:26 -0000

--===============1040316689888703595==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 24, 2017, 4:08 p.m., Aihua Xu wrote:
> >

Hi Aihua,

Can you please help to review my change and provide suggestions?

Thanks


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57009/#review166717
-----------------------------------------------------------


On May 23, 2017, 7:14 a.m., Eric Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57009/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 7:14 a.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-16029
>     https://issues.apache.org/jira/browse/HIVE-16029
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See the test case below:
> 
> {code}
> 0: jdbc:hive2://localhost:10000/default> select * from collect_set_test;
> +---------------------+
> | collect_set_test.a  |
> +---------------------+
> | 1                   |
> | 2                   |
> | NULL                |
> | 4                   |
> | NULL                |
> +---------------------+
> 
> 0: jdbc:hive2://localhost:10000/default> select collect_set(a) from collect_set_test;
> +---------------+
> |      _c0      |
> +---------------+
> | [1,2,4]  |
> +---------------+
> 
> {code}
> 
> The correct result should be:
> 
> {code}
> 0: jdbc:hive2://localhost:10000/default> select collect_set(a) from collect_set_test;
> +---------------+
> |      _c0      |
> +---------------+
> | [1,2,null,4]  |
> +---------------+
> {code}
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java 156d19b 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java 0c2cf90 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd 
>   ql/src/test/results/clientpositive/llap/udaf_collect_set_2.q.out aa55979 
>   ql/src/test/results/clientpositive/spark/udaf_collect_set.q.out ee152ca 
>   ql/src/test/results/clientpositive/udaf_collect_set.q.out ee152ca 
>   ql/src/test/results/clientpositive/udaf_collect_set_2.q.out f2e76a7 
> 
> 
> Diff: https://reviews.apache.org/r/57009/diff/3/
> 
> 
> Testing
> -------
> 
> Manully tested and confirmed result is correct:
> 
> {code}
> 0: jdbc:hive2://localhost:10000/default> select collect_set(a) from collect_set_test;
> +---------------+
> |      _c0      |
> +---------------+
> | [1,2,null,4]  |
> +---------------+
> {code}
> 
> 
> Thanks,
> 
> Eric Lin
> 
>


--===============1040316689888703595==--